From: Dmitry Osipenko <digetx@gmail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: Linus Walleij <linus.walleij@linaro.org>,
thierry.reding@gmail.com, Jon Hunter <jonathanh@nvidia.com>,
Marcel Ziswiler <marcel@ziswiler.com>,
linux-tegra@vger.kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] pinctrl: tegra: Move drivers registration to arch_init level
Date: Mon, 06 Aug 2018 16:38:22 +0300 [thread overview]
Message-ID: <2282091.6Fec9mOu3z@dimapc> (raw)
In-Reply-To: <e60cd1f07f7c7515c117fa3446914c7f@agner.ch>
On Monday, 6 August 2018 16:03:01 MSK Stefan Agner wrote:
> On 04.08.2018 16:01, Dmitry Osipenko wrote:
> > On Friday, 3 August 2018 20:24:56 MSK Linus Walleij wrote:
> >> On Thu, Aug 2, 2018 at 1:31 PM Stefan Agner <stefan@agner.ch> wrote:
> >> > A while back at least using those init lists were not well received
> >> > even
> >> > for GPIO/pinctrl drivers:
> >> >
> >> > https://lore.kernel.org/lkml/CACRpkdYk0zW12qNXgOstTLmdVDYacu0Un+8quTN+J
> >> > _az
> >> > Oic7AA@mail.gmail.com/T/#mf0596982324a6489b5537b0531ac5aed60a316ba
> >>
> >> You shouldn't listen too much to that guy he's not trustworthy.
>
> ;-)
>
> >> > I still think we should make an exception for GPIO/pinctrl and use
> >> > earlier initcalls. Platform GPIO/pinctrl drivers provide basic
> >> > infrastructure often used by many other drivers, we want to have them
> >> > loaded early. It avoids unnecessary EPROBE_DEFER and hence probably
> >> > even
> >> > boots faster.
> >>
> >> When we have the pin control and GPIO at different initlevels it makes me
> >> uneasy because I feel we have implicit init dependencies that seem more
> >> than a little fragile.
> >
> > Yes, it is not very good.
>
> Btw, just noticed this now:
> GPIO driver -> arch_initcall
> pinctrl driver -> subsys_initcall
I'm not sure what you're talking about, it's the other way around in the
patches.
next prev parent reply other threads:[~2018-08-06 13:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 11:11 [PATCH v1 1/2] pinctrl: tegra: Move drivers registration to arch_init level Dmitry Osipenko
2018-08-02 11:11 ` [PATCH v1 2/2] gpio: tegra: Move driver registration to subsys_init level Dmitry Osipenko
2018-08-02 11:31 ` [PATCH v1 1/2] pinctrl: tegra: Move drivers registration to arch_init level Stefan Agner
2018-08-03 17:24 ` Linus Walleij
2018-08-04 14:01 ` Dmitry Osipenko
2018-08-06 13:03 ` Stefan Agner
2018-08-06 13:38 ` Dmitry Osipenko [this message]
2018-08-06 21:01 ` Stefan Agner
2018-08-02 13:01 ` Dmitry Osipenko
2018-08-06 9:15 ` Dmitry Osipenko
2018-08-06 10:37 ` Linus Walleij
2018-08-03 17:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2282091.6Fec9mOu3z@dimapc \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel@ziswiler.com \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).