linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: David Wu <david.wu@rock-chips.com>
Cc: linus.walleij@linaro.org, huangtao@rock-chips.com,
	dianders@chromium.org, linux-rockchip@lists.infradead.org,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: rockchip: Use common interface for recalced iomux
Date: Fri, 21 Jul 2017 11:35:23 +0200	[thread overview]
Message-ID: <2301545.dlea0HVRYo@phil> (raw)
In-Reply-To: <1500618435-15092-2-git-send-email-david.wu@rock-chips.com>

Am Freitag, 21. Juli 2017, 14:27:14 CEST schrieb David Wu:
> The other Socs also need the feature of recalced iomux, so
> make it as a common interface like iomux route feature.
> 
> Signed-off-by: David Wu <david.wu@rock-chips.com>
> ---
>  drivers/pinctrl/pinctrl-rockchip.c | 89 +++++++++++++++++++++-----------------
>  1 file changed, 50 insertions(+), 39 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index e831647..fd4e491 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -76,7 +76,6 @@ enum rockchip_pinctrl_type {
>  #define IOMUX_SOURCE_PMU	BIT(2)
>  #define IOMUX_UNROUTED		BIT(3)
>  #define IOMUX_WIDTH_3BIT	BIT(4)
> -#define IOMUX_RECALCED		BIT(5)

very cool to see this flag go away and simply calculating the affected
bits is obviously a way nicer solution.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Thanks for that cleanup
Heiko


  reply	other threads:[~2017-07-21  9:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21  6:27 [PATCH 0/2] Add RK3128 pinctrl support David Wu
2017-07-21  6:27 ` [PATCH 1/2] pinctrl: rockchip: Use common interface for recalced iomux David Wu
2017-07-21  9:35   ` Heiko Stuebner [this message]
2017-08-03  7:30   ` Linus Walleij
2017-07-21  6:27 ` [PATCH 2/2] pinctrl: rockchip: Add rk3128 pinctrl support David Wu
2017-07-21  9:38   ` Heiko Stuebner
2017-08-03  7:32   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2301545.dlea0HVRYo@phil \
    --to=heiko@sntech.de \
    --cc=david.wu@rock-chips.com \
    --cc=dianders@chromium.org \
    --cc=huangtao@rock-chips.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).