From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Conor Dooley <mail@conchuod.ie>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor.dooley@microchip.com>,
Atul Khare <atulkhare@rivosinc.com>,
Sagar Kadam <sagar.kadam@sifive.com>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: sifive: add cache-set value of 2048
Date: Tue, 26 Jul 2022 19:35:25 +0200 [thread overview]
Message-ID: <246f132a-a23d-7c53-38a7-2bcec50d65e5@linaro.org> (raw)
In-Reply-To: <20220726170725.3245278-2-mail@conchuod.ie>
On 26/07/2022 19:07, Conor Dooley wrote:
> From: Atul Khare <atulkhare@rivosinc.com>
>
> Fixes Running device tree schema validation error messages like
> '... cache-sets:0:0: 1024 was expected'.
>
> The existing bindings had a single enumerated value of 1024, which
> trips up the dt-schema checks. The ISA permits any arbitrary power
> of two for the cache-sets value, but we decided to add the single
> additional value of 2048 because we couldn't spot an obvious way
> to express the constraint in the schema.
There is no way to express "power of two" but enum for multiple values
would work. Is there a reason to limit only to 2048?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-26 17:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 17:07 [PATCH v3 0/2] Fix SiFive dt-schema errors Conor Dooley
2022-07-26 17:07 ` [PATCH v3 1/2] dt-bindings: sifive: add cache-set value of 2048 Conor Dooley
2022-07-26 17:35 ` Krzysztof Kozlowski [this message]
2022-07-26 17:39 ` Conor.Dooley
2022-07-27 7:13 ` Krzysztof Kozlowski
2022-07-27 7:19 ` Conor.Dooley
2022-07-26 17:07 ` [PATCH v3 2/2] dt-bindings: sifive: add gpio-line-names Conor Dooley
2022-07-27 15:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=246f132a-a23d-7c53-38a7-2bcec50d65e5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=atulkhare@rivosinc.com \
--cc=brgl@bgdev.pl \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mail@conchuod.ie \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sagar.kadam@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).