* [PATCH] Documentation: gpio: fix bindings document
@ 2015-01-15 8:52 Masahiro Yamada
2015-01-15 14:00 ` Laurent Pinchart
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Masahiro Yamada @ 2015-01-15 8:52 UTC (permalink / raw)
To: devicetree
Cc: Linus Walleij, Mika Westerberg, Arnd Bergmann, Alexandre Courbot,
Stephen Warren, linux-gpio, Masahiro Yamada, Rob Herring,
Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Laurent Pinchart, linux-kernel
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
Documentation/devicetree/bindings/gpio/gpio.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt b/Documentation/devicetree/bindings/gpio/gpio.txt
index b9bd1d6..f7a158d 100644
--- a/Documentation/devicetree/bindings/gpio/gpio.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio.txt
@@ -69,7 +69,8 @@ GPIO pin number, and GPIO flags as accepted by the "qe_pio_e" gpio-controller.
----------------------------------
A gpio-specifier should contain a flag indicating the GPIO polarity; active-
-high or active-low. If it does, the follow best practices should be followed:
+high or active-low. If it does, the following best practices should be
+followed:
The gpio-specifier's polarity flag should represent the physical level at the
GPIO controller that achieves (or represents, for inputs) a logically asserted
@@ -147,7 +148,7 @@ contains information structures as follows:
numeric-gpio-range ::=
<pinctrl-phandle> <gpio-base> <pinctrl-base> <count>
named-gpio-range ::= <pinctrl-phandle> <gpio-base> '<0 0>'
- gpio-phandle : phandle to pin controller node.
+ pinctrl-phandle : phandle to pin controller node
gpio-base : Base GPIO ID in the GPIO controller
pinctrl-base : Base pinctrl pin ID in the pin controller
count : The number of GPIOs/pins in this range
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Documentation: gpio: fix bindings document
2015-01-15 8:52 [PATCH] Documentation: gpio: fix bindings document Masahiro Yamada
@ 2015-01-15 14:00 ` Laurent Pinchart
2015-01-15 14:07 ` Rob Herring
2015-01-19 10:34 ` Linus Walleij
2 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2015-01-15 14:00 UTC (permalink / raw)
To: Masahiro Yamada
Cc: devicetree, Linus Walleij, Mika Westerberg, Arnd Bergmann,
Alexandre Courbot, Stephen Warren, linux-gpio, Rob Herring,
Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, linux-kernel
Hi Yamada-san,
Thank you for the patch.
On Thursday 15 January 2015 17:52:40 Masahiro Yamada wrote:
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> Documentation/devicetree/bindings/gpio/gpio.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt
> b/Documentation/devicetree/bindings/gpio/gpio.txt index b9bd1d6..f7a158d
> 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio.txt
> @@ -69,7 +69,8 @@ GPIO pin number, and GPIO flags as accepted by the
> "qe_pio_e" gpio-controller. ----------------------------------
>
> A gpio-specifier should contain a flag indicating the GPIO polarity;
> active- -high or active-low. If it does, the follow best practices should
> be followed: +high or active-low. If it does, the following best practices
> should be +followed:
>
> The gpio-specifier's polarity flag should represent the physical level at
> the GPIO controller that achieves (or represents, for inputs) a logically
> asserted @@ -147,7 +148,7 @@ contains information structures as follows:
> numeric-gpio-range ::=
> <pinctrl-phandle> <gpio-base> <pinctrl-base> <count>
> named-gpio-range ::= <pinctrl-phandle> <gpio-base> '<0 0>'
> - gpio-phandle : phandle to pin controller node.
> + pinctrl-phandle : phandle to pin controller node
> gpio-base : Base GPIO ID in the GPIO controller
> pinctrl-base : Base pinctrl pin ID in the pin controller
> count : The number of GPIOs/pins in this range
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: gpio: fix bindings document
2015-01-15 8:52 [PATCH] Documentation: gpio: fix bindings document Masahiro Yamada
2015-01-15 14:00 ` Laurent Pinchart
@ 2015-01-15 14:07 ` Rob Herring
2015-01-15 14:10 ` Laurent Pinchart
2015-01-19 10:34 ` Linus Walleij
2 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2015-01-15 14:07 UTC (permalink / raw)
To: Masahiro Yamada
Cc: devicetree@vger.kernel.org, Linus Walleij, Mika Westerberg,
Arnd Bergmann, Alexandre Courbot, Stephen Warren,
linux-gpio@vger.kernel.org, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Laurent Pinchart,
linux-kernel@vger.kernel.org
On Thu, Jan 15, 2015 at 2:52 AM, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Perhaps some explanation. You can't just remove properties. Please
explain to what extent the old/wrong name is used. This patch is only
okay if there are no users of gpio-phandle.
Rob
> ---
>
> Documentation/devicetree/bindings/gpio/gpio.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt b/Documentation/devicetree/bindings/gpio/gpio.txt
> index b9bd1d6..f7a158d 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio.txt
> @@ -69,7 +69,8 @@ GPIO pin number, and GPIO flags as accepted by the "qe_pio_e" gpio-controller.
> ----------------------------------
>
> A gpio-specifier should contain a flag indicating the GPIO polarity; active-
> -high or active-low. If it does, the follow best practices should be followed:
> +high or active-low. If it does, the following best practices should be
> +followed:
>
> The gpio-specifier's polarity flag should represent the physical level at the
> GPIO controller that achieves (or represents, for inputs) a logically asserted
> @@ -147,7 +148,7 @@ contains information structures as follows:
> numeric-gpio-range ::=
> <pinctrl-phandle> <gpio-base> <pinctrl-base> <count>
> named-gpio-range ::= <pinctrl-phandle> <gpio-base> '<0 0>'
> - gpio-phandle : phandle to pin controller node.
> + pinctrl-phandle : phandle to pin controller node
> gpio-base : Base GPIO ID in the GPIO controller
> pinctrl-base : Base pinctrl pin ID in the pin controller
> count : The number of GPIOs/pins in this range
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: gpio: fix bindings document
2015-01-15 14:07 ` Rob Herring
@ 2015-01-15 14:10 ` Laurent Pinchart
2015-01-16 1:20 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2015-01-15 14:10 UTC (permalink / raw)
To: Rob Herring
Cc: Masahiro Yamada, devicetree@vger.kernel.org, Linus Walleij,
Mika Westerberg, Arnd Bergmann, Alexandre Courbot, Stephen Warren,
linux-gpio@vger.kernel.org, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, linux-kernel@vger.kernel.org
Hi Rob,
On Thursday 15 January 2015 08:07:18 Rob Herring wrote:
> On Thu, Jan 15, 2015 at 2:52 AM, Masahiro Yamada
>
> <yamada.m@jp.panasonic.com> wrote:
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
>
> Perhaps some explanation. You can't just remove properties. Please
> explain to what extent the old/wrong name is used. This patch is only
> okay if there are no users of gpio-phandle.
As far as I understand the patch just fixes a typo. There has never been a
gpio-phandle for GPIO controllers, only for GPIO consumers.
> > ---
> >
> > Documentation/devicetree/bindings/gpio/gpio.txt | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt
> > b/Documentation/devicetree/bindings/gpio/gpio.txt index b9bd1d6..f7a158d
> > 100644
> > --- a/Documentation/devicetree/bindings/gpio/gpio.txt
> > +++ b/Documentation/devicetree/bindings/gpio/gpio.txt
> > @@ -69,7 +69,8 @@ GPIO pin number, and GPIO flags as accepted by the
> > "qe_pio_e" gpio-controller.>
> > ----------------------------------
> >
> > A gpio-specifier should contain a flag indicating the GPIO polarity;
> > active->
> > -high or active-low. If it does, the follow best practices should be
> > followed: +high or active-low. If it does, the following best practices
> > should be>
> > +followed:
> > The gpio-specifier's polarity flag should represent the physical level at
> > the GPIO controller that achieves (or represents, for inputs) a
> > logically asserted>
> > @@ -147,7 +148,7 @@ contains information structures as follows:
> > numeric-gpio-range ::=
> >
> > <pinctrl-phandle> <gpio-base> <pinctrl-base>
> > <count>
> >
> > named-gpio-range ::= <pinctrl-phandle> <gpio-base> '<0 0>'
> >
> > - gpio-phandle : phandle to pin controller node.
> > + pinctrl-phandle : phandle to pin controller node
> >
> > gpio-base : Base GPIO ID in the GPIO controller
> > pinctrl-base : Base pinctrl pin ID in the pin controller
> > count : The number of GPIOs/pins in this range
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: gpio: fix bindings document
2015-01-15 14:10 ` Laurent Pinchart
@ 2015-01-16 1:20 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2015-01-16 1:20 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Rob Herring, devicetree@vger.kernel.org, Linus Walleij,
Mika Westerberg, Arnd Bergmann, Alexandre Courbot, Stephen Warren,
linux-gpio@vger.kernel.org, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, linux-kernel@vger.kernel.org
Hi Laurent, Rob,
On Thu, 15 Jan 2015 16:10:54 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> Hi Rob,
>
> On Thursday 15 January 2015 08:07:18 Rob Herring wrote:
> > On Thu, Jan 15, 2015 at 2:52 AM, Masahiro Yamada
> >
> > <yamada.m@jp.panasonic.com> wrote:
> > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> >
> > Perhaps some explanation. You can't just remove properties. Please
> > explain to what extent the old/wrong name is used. This patch is only
> > okay if there are no users of gpio-phandle.
>
> As far as I understand the patch just fixes a typo. There has never been a
> gpio-phandle for GPIO controllers, only for GPIO consumers.
Yes, this patch just fixes typos.
I thought I could be lazy here...
> > > ---
> > >
> > > Documentation/devicetree/bindings/gpio/gpio.txt | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt
> > > b/Documentation/devicetree/bindings/gpio/gpio.txt index b9bd1d6..f7a158d
> > > 100644
> > > --- a/Documentation/devicetree/bindings/gpio/gpio.txt
> > > +++ b/Documentation/devicetree/bindings/gpio/gpio.txt
> > > @@ -69,7 +69,8 @@ GPIO pin number, and GPIO flags as accepted by the
> > > "qe_pio_e" gpio-controller.>
> > > ----------------------------------
> > >
> > > A gpio-specifier should contain a flag indicating the GPIO polarity;
> > > active->
> > > -high or active-low. If it does, the follow best practices should be
> > > followed: +high or active-low. If it does, the following best practices
> > > should be>
> > > +followed:
> > > The gpio-specifier's polarity flag should represent the physical level at
> > > the GPIO controller that achieves (or represents, for inputs) a
> > > logically asserted>
> > > @@ -147,7 +148,7 @@ contains information structures as follows:
> > > numeric-gpio-range ::=
> > >
> > > <pinctrl-phandle> <gpio-base> <pinctrl-base>
> > > <count>
> > >
> > > named-gpio-range ::= <pinctrl-phandle> <gpio-base> '<0 0>'
> > >
> > > - gpio-phandle : phandle to pin controller node.
> > > + pinctrl-phandle : phandle to pin controller node
> > >
> > > gpio-base : Base GPIO ID in the GPIO controller
> > > pinctrl-base : Base pinctrl pin ID in the pin controller
> > > count : The number of GPIOs/pins in this range
>
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: gpio: fix bindings document
2015-01-15 8:52 [PATCH] Documentation: gpio: fix bindings document Masahiro Yamada
2015-01-15 14:00 ` Laurent Pinchart
2015-01-15 14:07 ` Rob Herring
@ 2015-01-19 10:34 ` Linus Walleij
2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2015-01-19 10:34 UTC (permalink / raw)
To: Masahiro Yamada
Cc: devicetree@vger.kernel.org, Mika Westerberg, Arnd Bergmann,
Alexandre Courbot, Stephen Warren, linux-gpio@vger.kernel.org,
Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Laurent Pinchart, linux-kernel@vger.kernel.org
On Thu, Jan 15, 2015 at 9:52 AM, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Patch applied with Laurent's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-19 10:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-15 8:52 [PATCH] Documentation: gpio: fix bindings document Masahiro Yamada
2015-01-15 14:00 ` Laurent Pinchart
2015-01-15 14:07 ` Rob Herring
2015-01-15 14:10 ` Laurent Pinchart
2015-01-16 1:20 ` Masahiro Yamada
2015-01-19 10:34 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).