From: Lars Poeschel <poeschel@lemonage.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH] gpio: adnp: rename "virq" to "child_irq"
Date: Mon, 14 Oct 2013 11:25:12 +0200 [thread overview]
Message-ID: <2498682.Tok0xRnD2G@lem-wkst-02> (raw)
In-Reply-To: <1381511518-5929-1-git-send-email-linus.walleij@linaro.org>
On Monday 14 October 2013 19:11:58, Linus Walleij wrote:
> This variable is confusingly named, the different Linux IRQs
> aren't any more virtual than any other Linux IRQ. Give it a
> non-misleading name.
>
> Cc: Lars Poeschel <poeschel@lemonage.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/gpio-adnp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-adnp.c b/drivers/gpio/gpio-adnp.c
> index 6439e0e..b204033 100644
> --- a/drivers/gpio/gpio-adnp.c
> +++ b/drivers/gpio/gpio-adnp.c
> @@ -325,9 +325,9 @@ static irqreturn_t adnp_irq(int irq, void *data)
> pending &= isr & ier;
>
> for_each_set_bit(bit, &pending, 8) {
> - unsigned int virq;
> - virq = irq_find_mapping(adnp->domain, base + bit);
> - handle_nested_irq(virq);
> + unsigned int child_irq;
> + child_irq = irq_find_mapping(adnp->domain, base + bit);
> + handle_nested_irq(child_irq);
> }
> }
Acked-by: Lars Poeschel <poeschel@lemonage.de>
prev parent reply other threads:[~2013-10-14 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 17:11 [PATCH] gpio: adnp: rename "virq" to "child_irq" Linus Walleij
2013-10-14 9:25 ` Lars Poeschel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2498682.Tok0xRnD2G@lem-wkst-02 \
--to=poeschel@lemonage.de \
--cc=acourbot@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox