From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 1/5] gpio: Cygnus: define Broadcom Cygnus GPIO binding Date: Mon, 08 Dec 2014 12:22:20 +0100 Message-ID: <2594176.SCRFa6Sb3O@wuerfel> References: <1418006316-324-2-git-send-email-rjui@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mout.kundenserver.de ([212.227.17.10]:58312 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbaLHLWm (ORCPT ); Mon, 8 Dec 2014 06:22:42 -0500 In-Reply-To: <1418006316-324-2-git-send-email-rjui@broadcom.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Ray Jui Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Linus Walleij , Alexandre Courbot , Grant Likely , Christian Daudt , Matt Porter , Florian Fainelli , Russell King , Joe Perches , Scott Branden , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org On Sunday 07 December 2014 18:38:32 Ray Jui wrote: > +Required properties: > + > +- compatible: > + Currently supported Cygnus GPIO controllers include: > + "brcm,cygnus-ccm-gpio": ChipcommonG GPIO controller > + "brcm,cygnus-asiu-gpio": ASIU GPIO controller > + "brcm,cygnus-crmu-gpio": CRMU GPIO controller How different are these? If they are almost the same, would it be better to use the same compatible string for all of them and describe the differences in extra properties? If they are rather different, maybe you should have a separate binding and driver for each? Arnd