From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 05/14] pinctrl: sh-pfc: r8a7795-es1: Use generic bias register description
Date: Wed, 04 Oct 2017 13:44:12 +0300 [thread overview]
Message-ID: <2599940.LmqJT7CgZ2@avalon> (raw)
In-Reply-To: <1744705.qyxHaYEude@avalon>
Hi Geert,
On Wednesday, 4 October 2017 13:40:13 EEST Laurent Pinchart wrote:
> On Wednesday, 4 October 2017 12:07:04 EEST Geert Uytterhoeven wrote:
> > Move R-Car H3 ES1.x bias support over to the generic way to describe
> > bias registers, which will be needed for suspend/resume support.
> >
> > As the new description is more compact, this decreases kernel size by
> > ca. 304 bytes.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
One additional comment, please see below.
> > ---
> >
> > drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c | 499 ++++++++++++-------------
> > 1 file changed, 258 insertions(+), 241 deletions(-)
> >
> > diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
> > b/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c index
> > 246d0de915feaffe..229192cf8e7430af 100644
> > --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
> > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
[snip]
> > +static const struct pinmux_bias_reg pinmux_bias_regs[] = {
[snip]
> > + { },
I would write it as { /* Sentinel */ } to make it more explicit that a last
zero entry is required.
> > };
[snip]
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-10-04 10:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 9:06 [PATCH 00/14] pinctrl: sh-pfc: Add suspend/resume support Geert Uytterhoeven
2017-10-04 9:07 ` [PATCH 01/14] pinctrl: sh-pfc: Remove matching on plain sh-pfc platform device Geert Uytterhoeven
2017-10-04 9:52 ` Laurent Pinchart
2017-10-04 9:07 ` [PATCH 02/14] pinctrl: sh-pfc: Drop width parameter of sh_pfc_{read,write}_reg() Geert Uytterhoeven
2017-10-04 9:55 ` Laurent Pinchart
2017-10-04 9:07 ` [PATCH 03/14] pinctrl: sh-pfc: Add generic bias register description Geert Uytterhoeven
2017-10-04 10:26 ` Laurent Pinchart
2017-10-04 9:07 ` [PATCH 04/14] pinctrl: sh-pfc: Add sh_pfc_pin_to_bias_reg() helper Geert Uytterhoeven
2017-10-04 10:12 ` Laurent Pinchart
2017-10-04 9:07 ` [PATCH 05/14] pinctrl: sh-pfc: r8a7795-es1: Use generic bias register description Geert Uytterhoeven
2017-10-04 10:40 ` Laurent Pinchart
2017-10-04 10:44 ` Laurent Pinchart [this message]
2017-10-04 9:07 ` [PATCH 06/14] pinctrl: sh-pfc: r8a7795: " Geert Uytterhoeven
2017-10-04 9:07 ` [PATCH 07/14] pinctrl: sh-pfc: r8a7796: " Geert Uytterhoeven
2017-10-04 9:07 ` [PATCH 08/14] pinctrl: sh-pfc: r8a7778: " Geert Uytterhoeven
2017-10-04 9:07 ` [PATCH 09/14] pinctrl: sh-pfc: Remove obsolete sh_pfc_pin_to_bias_info() Geert Uytterhoeven
2017-10-04 10:27 ` Laurent Pinchart
2017-10-04 9:07 ` [PATCH 10/14] pinctrl: sh-pfc: Add generic IOCTRL register description Geert Uytterhoeven
2017-10-04 9:07 ` [PATCH 11/14] pinctrl: sh-pfc: r8a7795-es1: Use " Geert Uytterhoeven
2017-10-04 9:07 ` [PATCH 12/14] pinctrl: sh-pfc: r8a7795: " Geert Uytterhoeven
2017-10-04 9:07 ` [PATCH 13/14] pinctrl: sh-pfc: r8a7796: " Geert Uytterhoeven
2017-10-04 9:07 ` [PATCH 14/14] pinctrl: sh-pfc: Save/restore registers for PSCI system suspend Geert Uytterhoeven
2017-10-04 19:19 ` [PATCH 00/14] pinctrl: sh-pfc: Add suspend/resume support Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2599940.LmqJT7CgZ2@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).