From: Christian Lamparter <chunkeey@gmail.com>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: Fix spelling of bias-pull-up
Date: Tue, 30 Apr 2019 23:32:17 +0200 [thread overview]
Message-ID: <2683948.V7X3pFLLSZ@debian64> (raw)
In-Reply-To: <20190428150822.13935-1-j.neuschaefer@gmx.net>
On Sunday, April 28, 2019 5:08:22 PM CEST Jonathan Neuschäfer wrote:
> The property is spelled 'bias-pull-up', as documented in
> pinctrl-bindings.txt.
>
I also sent out a patch for that... back in 2017:
https://patchwork.ozlabs.org/patch/763151/
It's marked Accepted and Archived.
@rob ?
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> .../devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt | 2 +-
> .../devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt | 2 +-
> .../devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt | 2 +-
> .../devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt | 2 +-
> .../devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt
> index c2dbb3e8d840..4e90ddd77784 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt
> @@ -42,7 +42,7 @@ information about e.g. the mux function.
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
>
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength,
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength,
> output-low, output-high.
>
> Non-empty subnodes must specify the 'pins' property.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt
> index 991be0cd0948..84be0f2c6f3b 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt
> @@ -44,7 +44,7 @@ information about e.g. the mux function.
>
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength.
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength.
>
> Non-empty subnodes must specify the 'pins' property.
> Note that not all properties are valid for all pins.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt
> index 7ed56a1b70fc..a7aaaa7db83b 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt
> @@ -42,7 +42,7 @@ information about e.g. the mux function.
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
>
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength,
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength,
> output-low, output-high.
>
> Non-empty subnodes must specify the 'pins' property.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt
> index cdc4787e59d2..f095209848c8 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt
> @@ -42,7 +42,7 @@ information about e.g. the mux function.
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
>
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength,
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength,
> output-low, output-high.
>
> Non-empty subnodes must specify the 'pins' property.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
> index c22e6c425d0b..004056506679 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt
> @@ -41,7 +41,7 @@ information about e.g. the mux function.
>
> The following generic properties as defined in pinctrl-bindings.txt are valid
> to specify in a pin configuration subnode:
> - pins, function, bias-disable, bias-pull-down, bias-pull,up, drive-strength.
> + pins, function, bias-disable, bias-pull-down, bias-pull-up, drive-strength.
>
> Non-empty subnodes must specify the 'pins' property.
> Note that not all properties are valid for all pins.
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-04-30 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 15:08 [PATCH] dt-bindings: pinctrl: Fix spelling of bias-pull-up Jonathan Neuschäfer
2019-04-30 21:32 ` Christian Lamparter [this message]
2019-05-02 19:55 ` Rob Herring
2019-05-16 12:44 ` Linus Walleij
2019-05-16 13:15 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2683948.V7X3pFLLSZ@debian64 \
--to=chunkeey@gmail.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).