From: "Fried, Ramon" <ramon.fried@linux.intel.com>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Linus Walleij <linus.walleij@linaro.org>,
brgl@bgdev.pl
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: gpiolib and pinmux interaction
Date: Tue, 30 Jul 2019 20:50:13 +0300 [thread overview]
Message-ID: <2790b597-25c9-82a5-9455-dbc7abbb5178@linux.intel.com> (raw)
In-Reply-To: <1ccdacac-c39b-cc99-3426-7682dc2baada@linux.intel.com>
On 7/30/2019 19:54, Fried, Ramon wrote:
>
> On 3/18/2019 13:41, Ramon Fried wrote:
>> On 3/18/19 11:21 AM, Stefan Wahren wrote:
>>> Hi Ramon,
>>>
>>> Am 17.03.19 um 10:09 schrieb Ramon Fried:
>>>> Hi Linus, Stefan,
>>>>
>>>> Great patch, If you need help testing it on other HW tell me.
>>> yes, please. I didn't get what kind of hardware you are using.
>> Hi.
>>
>> custom mips based SOC with sta2x11 gpio driver & proprietary pin
>> muxing ip allowing every pin to be muxed as gpio.
>>
>>> Regards
>>> Stefan
>
> Hey Linus, Stefan,
>
> I'm not sure where are we standing with the patch.
> I didn't find it merged, so I just took it and tested it. (It took my
> a while, hehe)
> It's working, but not as I would expect, instead of marking the gpio
> as used,
> it adds [kernel] flag. Which is OK, but I think it's clearer to also
> make the "used" column. (see below)
>
> What do you think ?
>
> Thanks,
>
> Ramon.
>
> See below:
>
> # gpioinfo
> gpiochip1 - 23 lines:
> line 0: unnamed unused input active-high
> line 1: unnamed unused input active-high
> line 2: unnamed unused input active-high
> line 3: unnamed unused input active-high
> line 4: unnamed unused input active-high
> line 5: unnamed unused input active-high
> line 6: unnamed unused input active-high
> line 7: unnamed unused input active-high
> line 8: unnamed unused input active-high [kernel]
> line 9: unnamed unused input active-high [kernel]
> line 10: unnamed unused input active-high [kernel]
> line 11: unnamed unused input active-high [kernel]
> line 12: unnamed unused input active-high
> line 13: unnamed unused input active-high
>
Adding Bartosz.
Turns out I was running and old version of libgpiod, in current version
it's printed "[used] instead of [kernel].
The patch from Stefan is perfectly fine from my standpoint, but the
output of gpioinfo can be improved,
I'll post a patch to LIBGPIOD.
Thanks.
Ramon
prev parent reply other threads:[~2019-07-30 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d031ce76-252a-9388-17fa-8a52f81f22f1@linux.intel.com>
[not found] ` <CACRpkdZUA33i+OVMH2KeKaBF368oGi9nW_GLawr+x9t=Gc67Ug@mail.gmail.com>
[not found] ` <bab378aa-8fb2-849c-9b73-3ed55ef9643e@linux.intel.com>
[not found] ` <2a08855b-9df2-e536-60c3-07770a9162b1@i2se.com>
[not found] ` <2218697f-8cb2-e20c-b8c9-c0386257aebf@linux.intel.com>
2019-07-30 16:54 ` gpiolib and pinmux interaction Fried, Ramon
2019-07-30 17:50 ` Fried, Ramon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2790b597-25c9-82a5-9455-dbc7abbb5178@linux.intel.com \
--to=ramon.fried@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox