From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>
Cc: Andre Przywara <andre.przywara@arm.com>,
Maxime Ripard <mripard@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: Re: Re: [PATCH 0/3] pinctrl: sunxi: Remove non-existent reset line references
Date: Wed, 01 Jun 2022 17:24:08 +0200 [thread overview]
Message-ID: <2828716.e9J7NaK4W3@kista> (raw)
In-Reply-To: <48570ec3-8159-11ae-8069-7f001081fd56@sholland.org>
Dne sreda, 01. junij 2022 ob 06:42:34 CEST je Samuel Holland napisal(a):
> Hi Jernej,
>
> On 5/31/22 10:22 AM, Jernej Škrabec wrote:
> > Dne torek, 31. maj 2022 ob 07:36:20 CEST je Samuel Holland napisal(a):
> >> I assume these properties came from a lack of documentation, and the
> >> very reasonable assumption that where there's a clock gate bit in the
> >> CCU, there's a reset bit. But the pin controllers are special and don't
> >> have a module reset line. The only way to reset the pin controller is to
> >> reset the whole VDD_SYS power domain.
> >>
> >> This series is preparation for converting the PRCM MFD and legacy clock
> >> drivers to a CCU clock/reset driver like all of the other Allwinner
> >> SoCs. I don't plan to add reset lines that don't actually exist to the
> >> new CCU driver. So we might as well get rid of the references now.
> >> Technically this breaks devicetree compatibility, since the old drivers
> >> expect the reset. But the CCU conversion will be a compatibility break
> >> anyway, so it's a bit of a moot point.
> >
> > If I understand correclty, this would cause only DT forward compatibility
> > issue, which happens now and then anyway. Kernel would still be compatible
> > with older DTs, it would just ignore that reset, right?
>
> Right, this only prevents older kernels from working with newer devicetrees.
I
> brought it up because I'm generally trying to minimize how much we do that.
All good then, this series is:
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
next prev parent reply other threads:[~2022-06-01 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 5:36 [PATCH 0/3] pinctrl: sunxi: Remove non-existent reset line references Samuel Holland
2022-05-31 5:36 ` [PATCH 1/3] pinctrl: sunxi: Remove reset controller consumers Samuel Holland
2022-05-31 5:36 ` [PATCH 2/3] ARM: dts: sunxi: Drop resets from r_pio nodes Samuel Holland
2022-05-31 5:36 ` [PATCH 3/3] dt-bindings: pinctrl: sunxi: Disallow the resets property Samuel Holland
2022-06-05 21:25 ` Rob Herring
2022-05-31 15:22 ` [PATCH 0/3] pinctrl: sunxi: Remove non-existent reset line references Jernej Škrabec
2022-06-01 4:42 ` Samuel Holland
2022-06-01 15:24 ` Jernej Škrabec [this message]
2022-06-15 13:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2828716.e9J7NaK4W3@kista \
--to=jernej.skrabec@gmail.com \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).