From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
"Luiz Angelo Daros de Luca" <luizluca@gmail.com>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: pinctrl: mt7620: add proper function muxing binding
Date: Wed, 14 Dec 2022 14:10:14 +0100 [thread overview]
Message-ID: <286bbd0f-1632-6071-7d08-e56ed16c234c@linaro.org> (raw)
In-Reply-To: <e4b6b334-44c3-9e73-adaa-9972ff9e6fd5@arinc9.com>
On 14/12/2022 14:03, Arınç ÜNAL wrote:
> On 14.12.2022 14:55, Krzysztof Kozlowski wrote:
>>>
>>> + allOf:
>>> + - if:
>>> + properties:
>>> + function:
>>> + const: antenna
>>> + then:
>>> + properties:
>>> + groups:
>>> + enum: [i2s]
>>
>> I have doubts such setup is maintainable and readable. I would suggest
>> to leave just few - maybe for gpio, jtag, refclk, utif.
>
> These bindings are not going to change once all properly defined and I'm
> here as a maintainer so I don't see an issue with maintaining the binding.
>
> It's the whole pin configuration of an SoC squashed under a single
> document. I guess this is the fate of the pinctrl bindings. The bindings
> for mt7622 is not so different:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/pinctrl/mediatek%2Cmt7622-pinctrl.yaml#n63
It's much smaller number of if:then: than yours but if you want to
manage it then sure:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-14 13:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 13:04 [PATCH 0/6] Enhance Ralink pinctrl documentation Arınç ÜNAL
2022-12-13 13:04 ` [PATCH 1/6] pinctrl: ralink: rename variables which point out the pin group Arınç ÜNAL
2022-12-13 13:04 ` [PATCH 2/6] dt-bindings: pinctrl: mt7620: add proper function muxing binding Arınç ÜNAL
2022-12-14 11:55 ` Krzysztof Kozlowski
2022-12-14 13:03 ` Arınç ÜNAL
2022-12-14 13:10 ` Krzysztof Kozlowski [this message]
2022-12-13 13:04 ` [PATCH 3/6] dt-bindings: pinctrl: mt7621: " Arınç ÜNAL
2022-12-14 13:13 ` Krzysztof Kozlowski
2022-12-13 13:04 ` [PATCH 4/6] dt-bindings: pinctrl: rt2880: " Arınç ÜNAL
2022-12-13 13:04 ` [PATCH 5/6] dt-bindings: pinctrl: rt305x: " Arınç ÜNAL
2022-12-13 13:04 ` [PATCH 6/6] dt-bindings: pinctrl: rt3883: " Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=286bbd0f-1632-6071-7d08-e56ed16c234c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arinc.unal@arinc9.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).