Re: [PATCH v1 1/3] gpio: Add APM X-Gene standby GPIO controller driver

Arnd Bergmann
2014-12-16T09:56:27Z

On Tuesday 16 December 2014 16:43:02 Y Vo wrote:
> >> +static int xgene_gpio_sb_get(struct gpio_chip *gc, u32 gpio)
> >> +{
> >> + struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
> >> + struct xgene_gpio_sb *chip = to_xgene_gpio_sb(mm_gc);
> >> + u32 data;
> >> +
> >> + data = ioread32(mm_gc->regs + MPA_GPIO_IN_ADDR);
> >> +
> >> + return (data & GPIO_MASK(gpio)) ? 1 : 0;
> >> +}
> >
> > This would be actually broken, right? Maybe it's better to change the
> > driver so that it refuses to map GPIO lines that are hardwired to
> > the interrupt controller, until we can support that.
>
> It still works if they are configure as GPIO.
> Do you have any reference to resolve it ?

Ok, I think I just misunderstood how this works, I assumed that you
could not reconfigure the lines. Seems ok then.

Arnd