From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8C6FC433DF for ; Thu, 9 Jul 2020 15:04:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 783C020720 for ; Thu, 9 Jul 2020 15:04:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="TJDX81hB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726832AbgGIPE0 (ORCPT ); Thu, 9 Jul 2020 11:04:26 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:17901 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726615AbgGIPEZ (ORCPT ); Thu, 9 Jul 2020 11:04:25 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 09 Jul 2020 08:04:13 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 09 Jul 2020 08:04:25 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 09 Jul 2020 08:04:25 -0700 Received: from [10.19.64.157] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 9 Jul 2020 15:04:22 +0000 Subject: Re: [PATCH v3 6/6] gpio: max77620: Initialize hardware state of interrupts To: Dmitry Osipenko , Thierry Reding , Jonathan Hunter , "Bartosz Golaszewski" , Linus Walleij , Andy Shevchenko References: <20200708202355.28507-1-digetx@gmail.com> <20200708202355.28507-7-digetx@gmail.com> CC: , , From: Laxman Dewangan Message-ID: <2a3295f9-7473-9251-b416-ef51ec85503a@nvidia.com> Date: Thu, 9 Jul 2020 20:33:49 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20200708202355.28507-7-digetx@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1594307053; bh=7F3rzQDKgl7FQApvtxRIrElxd/Edv/P96dYc+8+Bwh8=; h=X-PGP-Universal:Subject:To:References:CC:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding; b=TJDX81hB/r+VhtGfMVORT8pTrZODuSdgamsbR5BAxgx9ZLnNgScAMnDyiQac+6gnk 87ZZvpCwNZCiGFQL5DmdyRqTwziaCGs6yLQoHcpYeQtP2DEebV5vDZhZgVb42iDU3f OW2lJqHPYur0My8UdTN3dIlzjwW+4ahC7rpt8xP64LWeJnnqY32raBODOKrHB8KOt7 GP86lOphDNT5+okJhiPEuFdt0AiiVoxJgu111evfhKH6mFj5+tp8IS2ay+HNy5QsbW VjofFDJjfadNxEbGoHqp5GEymC/ThFs5MwTT+F0v3/aDe2r4lw1FfBBajQX+MOGGtm S1zVO8c5a/9qg== Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thursday 09 July 2020 01:53 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > I noticed on Nexus 7 that after rebooting from downstream kernel to > upstream, the GPIO interrupt is triggering non-stop despite interrupts > being disabled for all of GPIOs. This happens because Nexus 7 uses a > soft-reboot, meaning that bootloader should take care of resetting > hardware, but the bootloader doesn't do it well. As a result, GPIO > interrupt may be left ON at a boot time. Let's mask all GPIO interrupts > at the driver's initialization time in order to resolve the issue. > > Signed-off-by: Dmitry Osipenko > Looks good to me. Acked-by: Laxman Dewangan