From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linus.walleij@linaro.org, biju.das.jz@bp.renesas.com,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] pinctrl: renesas: rzg2l: Fix ISEL restore on resume
Date: Tue, 30 Sep 2025 08:33:15 +0300 [thread overview]
Message-ID: <2bd09757-cd66-4a2a-8801-0f62dc99b9c8@tuxon.dev> (raw)
In-Reply-To: <ef82c610-0571-4665-a5d1-07a9ed9fb8d3@tuxon.dev>
Hi, Geert,
On 9/29/25 15:10, Claudiu Beznea wrote:
>> This conflicts with commit d57183d06851bae4 ("pinctrl: renesas: rzg2l:
>> Drop unnecessary pin configurations"), which I have already queued
>> in renesas-drivers/renesas-pinctrl-for-v6.19. Hence I am replacing
>> the above hunk by:
>>
>> /* Switching to GPIO is not required if reset value is
>> same as func */
>> reg = readb(pctrl->base + PMC(off));
>> - spin_lock_irqsave(&pctrl->lock, flags);
>> + raw_spin_lock_irqsave(&pctrl->lock, flags);
>> pfc = readl(pctrl->base + PFC(off));
>> if ((reg & BIT(pin)) && (((pfc >> (pin * 4)) & PFC_MASK) == func)) {
>> - spin_unlock_irqrestore(&pctrl->lock, flags);
>> + raw_spin_unlock_irqrestore(&pctrl->lock, flags);
>> return;
>> }
>>
>> while applying.
> This is right. Thank you! I'm going to give it also a try (on actual HW) a
> bit later. I'll let you know.
Sorry for the delay, all looks good to me (checked on RZ/G3S).
Thank you,
Claudiu
>
> Thank you,
> Claudiu
next prev parent reply other threads:[~2025-09-30 5:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 9:53 [PATCH v2] pinctrl: renesas: rzg2l: Fix ISEL restore on resume Claudiu
2025-09-29 12:03 ` Geert Uytterhoeven
2025-09-29 12:10 ` Claudiu Beznea
2025-09-30 5:33 ` Claudiu Beznea [this message]
2025-09-30 10:20 ` Geert Uytterhoeven
2025-09-30 10:24 ` Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bd09757-cd66-4a2a-8801-0f62dc99b9c8@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).