From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27D6C276048 for ; Tue, 30 Sep 2025 05:33:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759210403; cv=none; b=hvP8egOnYedQBWBRLFAHvQmK1OtOO49GSqzSzsnjZ77h5ODHNheGJiu6QcmebFi96uCVPpn8+gNCTsWcDROhV9QH5Ru8k5TXx9eweKaCFRlAAMbgEQCKdwyCuhujYrqla8qMbSOGzwswhy6NzHIZY402lgqKFM+4vq9dtW1pAPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759210403; c=relaxed/simple; bh=+zYHcq1PnJGmU//SbV0gpmoJSYNqd+MwGlmrpbux8Rk=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=ukiCq3T3mJhrCE4LNS+ww/Mw2lErTvwsl0YnKx0BV0qWPtNNAPwhi82ZZ3+5wfZRPgxyJ1Je9OUySK84TTxuexJoDZ2w49WREyddO4JR1UnBVo0O8asqGiKHWdbia2c7Vh9OKt0GbED6D62ydwY3mv0v8NyIkWy2R+T27nCgm4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=TI4uSpQw; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="TI4uSpQw" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3f0308469a4so3098374f8f.0 for ; Mon, 29 Sep 2025 22:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1759210399; x=1759815199; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=RcKZSqsNCClUnXNLZ+VWODkqJQUd67st9xIuGAhStQk=; b=TI4uSpQwWfQKYiW1tI6/8kA5Z+W7OMOqi0a4zllk1q8j+84RD0TwN0Du9UKkguXWhO W76z5mPf5mURJ4ve7m6CFUL+1+UsRX1pLFNYCGCwo3SFu01z3wnAa7RMnSU9BICyKlwO ld4kwDoZEKgwKlSsnd9aGwUYu82qT3Iho1o+MtzCQMBzgVs1uqg5u3ukbs5ZPNPGNodb 543neIkoKYOqLzvovMx5dWX6W7EHk5etHpXdVKHjH0jlEYrqJXmnvgrsndCmaHc0Xjbr jf9IHBQDX6BUC8KxoEkh0w/TJX3JwqnHOIlLZNgtum8ys1Mb2uOlKF8vBz4ICzOSZsa5 OtRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759210399; x=1759815199; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RcKZSqsNCClUnXNLZ+VWODkqJQUd67st9xIuGAhStQk=; b=ajcmsKKbHyOpLbhArLitl9Y8PKrcllkndMTkoLcttcLY/17lm/gHJOMRd3NpIhHtdo bb8IvOIWjMSYjsYFtHR6pML3s16pvZOxTHOYIBizdVPvWFCNDTXo2HoH4LQUS/FzjQAH X0t3mCYp2cmNY/8AxMh4Fde0tPne6qs4r288yy1PQoFAjJLtGIM3HgULiSkTSBE8bjGo yPfe9cX/TTEV/4VJojT1n7CZtqnMd+/vJf3q3i43Y4T7WHUaRtIL9JzhwhRuZBOjUte+ KRZn2tdbrWkBk2kxAkuFlg8TJcvy6d+F9JwxwD5lyDk20HZt8PHf/721F5oFQMsQCrd0 dPRA== X-Forwarded-Encrypted: i=1; AJvYcCWEuwZEFBHbMROS0yjG5cwFrhR3NcZ7e57KHMSDkKXRvOrJPGZ9zPqO/3xi+npUoeLwpmsTeNKAk/BC@vger.kernel.org X-Gm-Message-State: AOJu0YxhLEi3fG5k7fM1Ib2Jj0zKSWaWj8Pi7df0rhNTfj1mtx2wUrWu PwTIwFOU1U41i/+PBhtLlSellv8BB+f0x6q+XG/L+iSOs+nVEBFl0buLz12+YVz2IQE= X-Gm-Gg: ASbGncs7DWjPpgECHJUG5o/VVxa82+UTD7j6J/tuaEs9TlM/yrwxHH4bA8l5K+a5x1Z p/4rH/ayhwI2vN17yCASn0KTm+jT15hqtd5kPUE7o2CntU2iJJ0YZuU3/cKHmmyIW0atVKKAssF Yiy69V8sZMOWsvKXik8fx2I7RJVHrjh3JHrWhi8/RzFsdZYl3/1qt5lueFSpY1jXRqXo6kHi1I/ T9wjO6aRB/pPQ+JsqZRy3Dq4xLHa0UaLxLVpv5534ZLxtZBmEh0AzsmtInR/g4nrHkVh/upnVr5 0EiebBupM7vnk3MWcHllY43s2QuA2Xzrl7H/KMCcATQrjiO4DusOwd0NhiwL2Ske/ITsN9sVpWV 2zlV6Fo5eqRF0CdNlJY5pBcUkZEakxYhx9xZnzUHeFVfbi2/cUexQiOM= X-Google-Smtp-Source: AGHT+IEkueAS01kFVAoXd3MEH9FbKcaIHwo56QQ73i1m/EjHyO0vo1fWE9up8eTSOW6ZhEmF700+iQ== X-Received: by 2002:a05:6000:400a:b0:3e4:957d:d00 with SMTP id ffacd0b85a97d-40e4c2d2576mr17438762f8f.58.1759210399124; Mon, 29 Sep 2025 22:33:19 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.111]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fc88b0779sm20750915f8f.58.2025.09.29.22.33.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Sep 2025 22:33:18 -0700 (PDT) Message-ID: <2bd09757-cd66-4a2a-8801-0f62dc99b9c8@tuxon.dev> Date: Tue, 30 Sep 2025 08:33:15 +0300 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] pinctrl: renesas: rzg2l: Fix ISEL restore on resume From: Claudiu Beznea To: Geert Uytterhoeven Cc: linus.walleij@linaro.org, biju.das.jz@bp.renesas.com, linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea , stable@vger.kernel.org References: <20250912095308.3603704-1-claudiu.beznea.uj@bp.renesas.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Geert, On 9/29/25 15:10, Claudiu Beznea wrote: >> This conflicts with commit d57183d06851bae4 ("pinctrl: renesas: rzg2l: >> Drop unnecessary pin configurations"), which I have already queued >> in renesas-drivers/renesas-pinctrl-for-v6.19. Hence I am replacing >> the above hunk by: >> >> /* Switching to GPIO is not required if reset value is >> same as func */ >> reg = readb(pctrl->base + PMC(off)); >> - spin_lock_irqsave(&pctrl->lock, flags); >> + raw_spin_lock_irqsave(&pctrl->lock, flags); >> pfc = readl(pctrl->base + PFC(off)); >> if ((reg & BIT(pin)) && (((pfc >> (pin * 4)) & PFC_MASK) == func)) { >> - spin_unlock_irqrestore(&pctrl->lock, flags); >> + raw_spin_unlock_irqrestore(&pctrl->lock, flags); >> return; >> } >> >> while applying. > This is right. Thank you! I'm going to give it also a try (on actual HW) a > bit later. I'll let you know. Sorry for the delay, all looks good to me (checked on RZ/G3S). Thank you, Claudiu > > Thank you, > Claudiu