From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00260C7EE23 for ; Mon, 29 May 2023 15:21:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229819AbjE2PVH (ORCPT ); Mon, 29 May 2023 11:21:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbjE2PVG (ORCPT ); Mon, 29 May 2023 11:21:06 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD84FD2 for ; Mon, 29 May 2023 08:21:03 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-30a8fa6e6fcso2088315f8f.1 for ; Mon, 29 May 2023 08:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1685373662; x=1687965662; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TBUyi7GtvvTumLP5OPVjGqROpV802wvk7yxqnFgwTHY=; b=Msn7AW1khWORLn/oD/9VF15pkuplmldeqTa1sZH7PRTWzL9284dima5XY3ropCTDrd WkoMXDtdqR2n738N6PCPiPJ7E+Q8wE750FrMkHSK3SzZACRvtCw5iA2sX1itxo2rxocV Fryn5uTbDazceFQSQs0WI+0snyV8iQ1u0Lvd1K0VD4vQE+Gpxg5byq/SO/4P3c9QRBMR Tmv9l3R0W2rhDamU+x4TbngiA/DTWk3G47cgTVkWibvno3Ok+m2yBUFrPuNpCjRUbMbq lWtstpgFgaVncvS0Yj0/IPViUMLvBEpXEGMMunEziBT4rQZZ4A4MOaa+Lfxd8h2+fOYq sB3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685373662; x=1687965662; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TBUyi7GtvvTumLP5OPVjGqROpV802wvk7yxqnFgwTHY=; b=gjQN5ZAQXeDp6riGe7dQo16TxjX7yoLRWYOYDh0AW1jyhrN6CHhQsa7VwXYVrdg8gN 4h7y3aNvfe8aLZannTuL+MiZoJWYDpufzXR1jFNFs9yFNXHm6qIScVgM+E5QL/K5ZkE5 6SrOLPVY+LrI5rND0bWy5RJ6FnXL7A9gfxTxCkouo9nJ+iB5hGMjcO5EZ9hFd7CHikZP fDXmV68jMnmM49toTAs0AzOqgo72NADRpvQPc4Ua9tVLp9XysRE+y58mzsFRu7SELvnV w3v6R1XERvJAjeNeZ5J+vEYlbcPmXdpgCyMQW4KmhUk4xDB6mg/AI5D5hg5Qh/FONPj7 KNwA== X-Gm-Message-State: AC+VfDxBfPp4a3Rx/yrEuEbrBkULJQ4RTAi4OR/ZrDIwNuHbDyCRAy3n JqaAB9jHOZGn29EQ19SCKBFfKWBpUBXC3YPHhuFjYg== X-Google-Smtp-Source: ACHHUZ5QsPruAv4u4ZJBUO5E7KlnTJFL6JDOEHss86t1fBqmlCJvSruzkrQftYsvmoGskysj74HOAA== X-Received: by 2002:a5d:4e82:0:b0:30a:eadb:791b with SMTP id e2-20020a5d4e82000000b0030aeadb791bmr2551244wru.29.1685373662138; Mon, 29 May 2023 08:21:02 -0700 (PDT) Received: from [192.168.1.91] (192.201.68.85.rev.sfr.net. [85.68.201.192]) by smtp.gmail.com with ESMTPSA id y4-20020a056000108400b0030abe7c36b1sm241306wrw.93.2023.05.29.08.21.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 May 2023 08:21:01 -0700 (PDT) Message-ID: <2c970ea3-e927-4ea1-f378-a600e834cc9d@baylibre.com> Date: Mon, 29 May 2023 17:21:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 1/2] gpio: tps65219: add GPIO support for TPS65219 PMIC Content-Language: en-US To: andy.shevchenko@gmail.com Cc: Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Lee Jones , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Jonathan Cormier References: <20230511-tps65219-add-gpio-support-v3-0-19837a34d820@baylibre.com> <20230511-tps65219-add-gpio-support-v3-1-19837a34d820@baylibre.com> From: jerome Neanne In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 26/05/2023 20:15, andy.shevchenko@gmail.com wrote: > ... > > Missing bits.h > >> +#include >> +#include >> +#include >> +#include >> +#include > Thanks for your review.Just to be sure on this particular point: Your recommendation here it to include explicitly bits.h. I can see BIT_MASK(n) defined in linux/bits.h BIT(n) is defined in vdso/bits.h From what I can see, BIT(n) is broadly used across kernel but BIT_MASK(n) sounds to be the Linux strict way... In current version I'm using BIT(n) macro not BIT_MASK(n). Do you recommend to replace every BIT(n) currently used with BIT_MASK(n)? Sorry for asking dumb questions. Just trying to make sure I correctly/fully understand your feedback... And do it all right for the next iteration. Regards, Jerome.