* [PATCH 0/3] General Purpose clocks and matisse-wifi backlight @ 2023-01-06 11:44 Matti Lehtimäki 2023-01-06 11:44 ` [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks Matti Lehtimäki 2023-01-06 11:44 ` [PATCH 2/3] pinctrl: qcom: " Matti Lehtimäki 0 siblings, 2 replies; 9+ messages in thread From: Matti Lehtimäki @ 2023-01-06 11:44 UTC (permalink / raw) To: linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki, Bjorn Andersson, devicetree, Konrad Dybcio, linux-gpio, linux-kernel This series adds support for general purpose clocks found on MSM8226 and enables ti,lp8556 backlight on matisse-wifi which uses general purpose clocks with clk-pwm. Luca Weiss (1): pinctrl: qcom: msm8226: Add General Purpose clocks Matti Lehtimäki (2): dt-bindings: pinctrl: msm8226: Add General Purpose clocks ARM: dts: qcom: apq8026-samsung-matisse-wifi: Add display backlight .../pinctrl/qcom,msm8226-pinctrl.yaml | 4 +- .../dts/qcom-apq8026-samsung-matisse-wifi.dts | 59 +++++++++++++++++++ drivers/pinctrl/qcom/pinctrl-msm8226.c | 11 +++- 3 files changed, 70 insertions(+), 4 deletions(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks 2023-01-06 11:44 [PATCH 0/3] General Purpose clocks and matisse-wifi backlight Matti Lehtimäki @ 2023-01-06 11:44 ` Matti Lehtimäki 2023-01-06 12:32 ` Krzysztof Kozlowski ` (2 more replies) 2023-01-06 11:44 ` [PATCH 2/3] pinctrl: qcom: " Matti Lehtimäki 1 sibling, 3 replies; 9+ messages in thread From: Matti Lehtimäki @ 2023-01-06 11:44 UTC (permalink / raw) To: linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki, Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring, Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel Document the general purpose clock functions that are found on MSM8226. Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> --- .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml index 3b79f5be860b..6e3808065845 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml @@ -66,8 +66,8 @@ $defs: enum: [ gpio, cci_i2c0, blsp_uim1, blsp_uim2, blsp_uim3, blsp_uim5, blsp_i2c1, blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_spi1, blsp_spi2, blsp_spi3, blsp_spi5, blsp_uart1, blsp_uart2, - blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, sdc3, - wlan ] + blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, + gp0_clk, gp1_clk, sdc3, wlan ] bias-pull-down: true bias-pull-up: true -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks 2023-01-06 11:44 ` [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks Matti Lehtimäki @ 2023-01-06 12:32 ` Krzysztof Kozlowski 2023-01-06 12:41 ` Matti Lehtimäki 2023-01-06 13:00 ` Krzysztof Kozlowski 2023-01-10 7:57 ` Linus Walleij 2 siblings, 1 reply; 9+ messages in thread From: Krzysztof Kozlowski @ 2023-01-06 12:32 UTC (permalink / raw) To: Matti Lehtimäki, linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring, Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel On 06/01/2023 12:44, Matti Lehtimäki wrote: > Document the general purpose clock functions that are found on MSM8226. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > --- > .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > index 3b79f5be860b..6e3808065845 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > @@ -66,8 +66,8 @@ $defs: > enum: [ gpio, cci_i2c0, blsp_uim1, blsp_uim2, blsp_uim3, blsp_uim5, > blsp_i2c1, blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_spi1, > blsp_spi2, blsp_spi3, blsp_spi5, blsp_uart1, blsp_uart2, > - blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, sdc3, > - wlan ] > + blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, cam_mclk1, > + gp0_clk, gp1_clk, sdc3, wlan ] Driver does not support them (and there is no driver change, unless you cc-ed people selectively...). Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks 2023-01-06 12:32 ` Krzysztof Kozlowski @ 2023-01-06 12:41 ` Matti Lehtimäki 2023-01-06 13:00 ` Krzysztof Kozlowski 0 siblings, 1 reply; 9+ messages in thread From: Matti Lehtimäki @ 2023-01-06 12:41 UTC (permalink / raw) To: Krzysztof Kozlowski, linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring, Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel On 6.1.2023 14.32, Krzysztof Kozlowski wrote: > On 06/01/2023 12:44, Matti Lehtimäki wrote: >> + blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, >> cam_mclk1, + gp0_clk, gp1_clk, sdc3, wlan ] > > Driver does not support them (and there is no driver change, unless > you cc-ed people selectively...). The driver changes are in patch number 2 of the series, I used git send-mail with a cc script, which uses get_maintainer.pl to get the needed addresses for each patch, to send the patches. It probably didn't send every patch to everyone and would need some improvement. -Matti ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks 2023-01-06 12:41 ` Matti Lehtimäki @ 2023-01-06 13:00 ` Krzysztof Kozlowski 0 siblings, 0 replies; 9+ messages in thread From: Krzysztof Kozlowski @ 2023-01-06 13:00 UTC (permalink / raw) To: Matti Lehtimäki, linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring, Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel On 06/01/2023 13:41, Matti Lehtimäki wrote: > On 6.1.2023 14.32, Krzysztof Kozlowski wrote: >> On 06/01/2023 12:44, Matti Lehtimäki wrote: >>> + blsp_uart3, blsp_uart4, blsp_uart5, cam_mclk0, >>> cam_mclk1, + gp0_clk, gp1_clk, sdc3, wlan ] >> >> Driver does not support them (and there is no driver change, unless >> you cc-ed people selectively...). > > The driver changes are in patch number 2 of the series, I used > git send-mail with a cc script, which uses get_maintainer.pl to > get the needed addresses for each patch, to send the patches. It > probably didn't send every patch to everyone and would need some > improvement. Ah, ok, such method is recommended for big patchsets. In regular cases please Cc everyone for all patches. I am using this one: https://pastebin.com/HAjuht68 Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks 2023-01-06 11:44 ` [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks Matti Lehtimäki 2023-01-06 12:32 ` Krzysztof Kozlowski @ 2023-01-06 13:00 ` Krzysztof Kozlowski 2023-01-10 7:57 ` Linus Walleij 2 siblings, 0 replies; 9+ messages in thread From: Krzysztof Kozlowski @ 2023-01-06 13:00 UTC (permalink / raw) To: Matti Lehtimäki, linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij, Rob Herring, Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel On 06/01/2023 12:44, Matti Lehtimäki wrote: > Document the general purpose clock functions that are found on MSM8226. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > --- > .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks 2023-01-06 11:44 ` [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks Matti Lehtimäki 2023-01-06 12:32 ` Krzysztof Kozlowski 2023-01-06 13:00 ` Krzysztof Kozlowski @ 2023-01-10 7:57 ` Linus Walleij 2 siblings, 0 replies; 9+ messages in thread From: Linus Walleij @ 2023-01-10 7:57 UTC (permalink / raw) To: Matti Lehtimäki Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel On Fri, Jan 6, 2023 at 12:44 PM Matti Lehtimäki <matti.lehtimaki@gmail.com> wrote: > Document the general purpose clock functions that are found on MSM8226. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> Patch applied! Yours, Linus Walleij ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/3] pinctrl: qcom: msm8226: Add General Purpose clocks 2023-01-06 11:44 [PATCH 0/3] General Purpose clocks and matisse-wifi backlight Matti Lehtimäki 2023-01-06 11:44 ` [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks Matti Lehtimäki @ 2023-01-06 11:44 ` Matti Lehtimäki 2023-01-10 7:57 ` Linus Walleij 1 sibling, 1 reply; 9+ messages in thread From: Matti Lehtimäki @ 2023-01-06 11:44 UTC (permalink / raw) To: linux-arm-msm Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Matti Lehtimäki, Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij, linux-gpio, linux-kernel From: Luca Weiss <luca@z3ntu.xyz> Add support for the general purpose clocks that are found on MSM8226. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> Co-developed-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> --- drivers/pinctrl/qcom/pinctrl-msm8226.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-msm8226.c b/drivers/pinctrl/qcom/pinctrl-msm8226.c index fca0645e8008..0f05725e0a21 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm8226.c +++ b/drivers/pinctrl/qcom/pinctrl-msm8226.c @@ -362,6 +362,8 @@ enum msm8226_functions { MSM_MUX_cam_mclk0, MSM_MUX_cam_mclk1, MSM_MUX_cci_i2c0, + MSM_MUX_gp0_clk, + MSM_MUX_gp1_clk, MSM_MUX_gpio, MSM_MUX_sdc3, MSM_MUX_wlan, @@ -447,6 +449,9 @@ static const char * const cci_i2c0_groups[] = { "gpio29", "gpio30" }; static const char * const cam_mclk0_groups[] = { "gpio26" }; static const char * const cam_mclk1_groups[] = { "gpio27" }; +static const char * const gp0_clk_groups[] = { "gpio33" }; +static const char * const gp1_clk_groups[] = { "gpio34" }; + static const char * const sdc3_groups[] = { "gpio39", "gpio40", "gpio41", "gpio42", "gpio43", "gpio44" }; @@ -480,6 +485,8 @@ static const struct msm_function msm8226_functions[] = { FUNCTION(cam_mclk0), FUNCTION(cam_mclk1), FUNCTION(cci_i2c0), + FUNCTION(gp0_clk), + FUNCTION(gp1_clk), FUNCTION(gpio), FUNCTION(sdc3), FUNCTION(wlan), @@ -519,8 +526,8 @@ static const struct msm_pingroup msm8226_groups[] = { PINGROUP(30, cci_i2c0, NA, NA, NA, NA, NA, NA), PINGROUP(31, NA, NA, NA, NA, NA, NA, NA), PINGROUP(32, NA, NA, NA, NA, NA, NA, NA), - PINGROUP(33, NA, NA, NA, NA, NA, NA, NA), - PINGROUP(34, NA, NA, NA, NA, NA, NA, NA), + PINGROUP(33, NA, NA, gp0_clk, NA, NA, NA, NA), + PINGROUP(34, NA, NA, gp1_clk, NA, NA, NA, NA), PINGROUP(35, NA, NA, NA, NA, NA, NA, NA), PINGROUP(36, NA, NA, NA, NA, NA, NA, NA), PINGROUP(37, NA, NA, NA, NA, NA, NA, NA), -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] pinctrl: qcom: msm8226: Add General Purpose clocks 2023-01-06 11:44 ` [PATCH 2/3] pinctrl: qcom: " Matti Lehtimäki @ 2023-01-10 7:57 ` Linus Walleij 0 siblings, 0 replies; 9+ messages in thread From: Linus Walleij @ 2023-01-10 7:57 UTC (permalink / raw) To: Matti Lehtimäki Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross, Bjorn Andersson, Konrad Dybcio, linux-gpio, linux-kernel On Fri, Jan 6, 2023 at 12:44 PM Matti Lehtimäki <matti.lehtimaki@gmail.com> wrote: > From: Luca Weiss <luca@z3ntu.xyz> > > Add support for the general purpose clocks that are found on MSM8226. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > Co-developed-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> Patch applied! Please funnel patch 3/3 thru the SoC tree. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-01-10 7:59 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-01-06 11:44 [PATCH 0/3] General Purpose clocks and matisse-wifi backlight Matti Lehtimäki 2023-01-06 11:44 ` [PATCH 1/3] dt-bindings: pinctrl: msm8226: Add General Purpose clocks Matti Lehtimäki 2023-01-06 12:32 ` Krzysztof Kozlowski 2023-01-06 12:41 ` Matti Lehtimäki 2023-01-06 13:00 ` Krzysztof Kozlowski 2023-01-06 13:00 ` Krzysztof Kozlowski 2023-01-10 7:57 ` Linus Walleij 2023-01-06 11:44 ` [PATCH 2/3] pinctrl: qcom: " Matti Lehtimäki 2023-01-10 7:57 ` Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).