From: Stefan Wahren <wahrenst@gmx.net>
To: Bough Chen <haibo.chen@nxp.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [PATCH] gpio: vf610: always set GPIO to input mode when used as interrupt source
Date: Fri, 19 Jul 2024 05:53:24 +0200 [thread overview]
Message-ID: <2e66b506-0b09-41dd-bc67-8c6935ce5157@gmx.net> (raw)
In-Reply-To: <DU0PR04MB9496F701AE831C2DEDA6205390AD2@DU0PR04MB9496.eurprd04.prod.outlook.com>
Am 19.07.24 um 03:46 schrieb Bough Chen:
>> -----Original Message-----
>> From: Stefan Wahren <wahrenst@gmx.net>
>> Sent: 2024年7月19日 1:09
>> To: Bough Chen <haibo.chen@nxp.com>
>> Cc: Bartosz Golaszewski <brgl@bgdev.pl>; Linus Walleij
>> <linus.walleij@linaro.org>; open list:GPIO SUBSYSTEM
>> <linux-gpio@vger.kernel.org>; Linux Kernel Mailing List
>> <linux-kernel@vger.kernel.org>; imx@lists.linux.dev
>> Subject: Re: [PATCH] gpio: vf610: always set GPIO to input mode when used as
>> interrupt source
>>
>> Hi,
>>
>> I found this thread about the vf610 driver, because I noticed today that the
>> i.MX93 is missing the GPIO get_direction callback.
> I find the patch was wrong, we can't call gc.direction_input in vf610_gpio_irq_set_type(), because gc.direction_input will call pinctrl_gpio_direction_input(), this API can't be used in irq context.
>
> For get_direction callback, yes, I will send a patch this week.
Sounds great. You can add me to CC for it, because i'm usually
subscribed to linux-arm-kernel instead of linux-kernel.
Regards
prev parent reply other threads:[~2024-07-19 3:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 2:28 [PATCH] gpio: vf610: always set GPIO to input mode when used as interrupt source haibo.chen
2024-04-23 10:56 ` Bartosz Golaszewski
2024-04-23 11:40 ` Linus Walleij
2024-04-23 12:20 ` Bough Chen
2024-04-24 11:01 ` Bough Chen
2024-04-25 8:49 ` Bough Chen
2024-04-25 13:06 ` Bartosz Golaszewski
2024-04-28 2:31 ` Bough Chen
2024-07-18 17:08 ` Stefan Wahren
2024-07-19 1:46 ` Bough Chen
2024-07-19 3:53 ` Stefan Wahren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e66b506-0b09-41dd-bc67-8c6935ce5157@gmx.net \
--to=wahrenst@gmx.net \
--cc=brgl@bgdev.pl \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).