From: Chanwoo Choi <cw00.choi@samsung.com>
To: Linus Walleij <linus.walleij@linaro.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Mike Lockwood <lockwood@google.com>,
devicetree@vger.kernel.org,
"cpgs (cpgs@samsung.com)" <cpgs@samsung.com>
Subject: Re: [PATCH] extcon: fsa9480: Support the FSA880 variant
Date: Wed, 24 Jul 2019 19:12:01 +0900 [thread overview]
Message-ID: <2e832c87-71ea-af32-211d-a301cf58cb04@samsung.com> (raw)
In-Reply-To: <20190723174301.31278-1-linus.walleij@linaro.org>
On 19. 7. 24. 오전 2:43, Linus Walleij wrote:
> The older compatible variant of this chip is called FSA880
> and works the same way, if we need some quirks in the future,
> it is good to let it have its own compatible string.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt | 4 +++-
> drivers/extcon/extcon-fsa9480.c | 1 +
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt b/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt
> index d592c21245f2..624bd76f468e 100644
> --- a/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt
> +++ b/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt
> @@ -5,7 +5,9 @@ controlled using I2C and enables USB data, stereo and mono audio, video,
> microphone, and UART data to use a common connector port.
>
> Required properties:
> - - compatible : Must be "fcs,fsa9480"
> + - compatible : Must be one of
> + "fcs,fsa9480"
> + "fcs,fsa880"
> - reg : Specifies i2c slave address. Must be 0x25.
> - interrupts : Should contain one entry specifying interrupt signal of
> interrupt parent to which interrupt pin of the chip is connected.
> diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c
> index 350fb34abfa0..8405512f5199 100644
> --- a/drivers/extcon/extcon-fsa9480.c
> +++ b/drivers/extcon/extcon-fsa9480.c
> @@ -363,6 +363,7 @@ MODULE_DEVICE_TABLE(i2c, fsa9480_id);
>
> static const struct of_device_id fsa9480_of_match[] = {
> { .compatible = "fcs,fsa9480", },
> + { .compatible = "fcs,fsa880", },
> { },
> };
> MODULE_DEVICE_TABLE(of, fsa9480_of_match);
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
prev parent reply other threads:[~2019-07-24 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190723174344epcas3p4dc935720d75f93a5ca0181662bc8036f@epcas3p4.samsung.com>
2019-07-23 17:43 ` [PATCH] extcon: fsa9480: Support the FSA880 variant Linus Walleij
2019-07-24 10:12 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e832c87-71ea-af32-211d-a301cf58cb04@samsung.com \
--to=cw00.choi@samsung.com \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lockwood@google.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox