From: Nick Chan <towinchenmi@gmail.com>
To: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Mark Kettenis <kettenis@openbsd.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-watchdog@vger.kernel.org
Cc: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: [PATCH v2 03/22] dt-bindings: cpufreq: apple,cluster-cpufreq: Add A10 compatible
Date: Sun, 15 Sep 2024 01:17:57 +0800 [thread overview]
Message-ID: <2ebf5258-b55d-4010-aa94-d5bab1f93bb5@gmail.com> (raw)
In-Reply-To: <20240914052413.68177-6-towinchenmi@gmail.com>
On 14/9/2024 13:17, Nick Chan wrote:
> The block found on the Apple A10 SoC is compatible with the
> existing driver so just add its per-SoC compatible.
>
> Signed-off-by: Nick Chan <towinchenmi@gmail.com>
> ---
> .../devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml b/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml
> index 76cb9726660e..e0d1a9813696 100644
> --- a/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml
> @@ -24,7 +24,9 @@ properties:
> - apple,t8112-cluster-cpufreq
> - const: apple,cluster-cpufreq
> - items:
> - - const: apple,t6000-cluster-cpufreq
> + - enum:
> + - apple,t8010-cluster-cpufreq
> + - apple,t6000-cluster-cpufreq
> - const: apple,t8103-cluster-cpufreq
> - const: apple,cluster-cpufreq
>
Have to retract the cpufreq patches, a v3 without them will be available
tomorrow. cpufreq works on iPad 7 (A10). However it is already pretty
weird when the cpufreq did not work on Apple TV 4K (A10X), with adjusted
p-states. However, it seems that iPhone 7 (A10) is also not working. So
this is definitely broken. As far as the hardware interfaces go they should
be compatible, so the only explanation that makes sense is that the behavior
is not correct on t8010 and t8011 and it only *happened* to work on iPad 7,
with some incorrect behaviors.
Marked as deferred on patchwork.
Nick Chan
next prev parent reply other threads:[~2024-09-14 17:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 5:17 [PATCH v2 00/22] Initial device trees for A7-A11 based Apple devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 01/22] dt-bindings: arm: cpus: Add Apple A7-A11 CPU cores Nick Chan
2024-09-14 5:17 ` [PATCH v2 02/22] dt-bindings: watchdog: apple,wdt: Add A7-A11 compatibles Nick Chan
2024-09-14 5:17 ` [PATCH v2 03/22] dt-bindings: cpufreq: apple,cluster-cpufreq: Add A10 compatible Nick Chan
2024-09-14 17:17 ` Nick Chan [this message]
2024-09-14 22:23 ` Conor Dooley
2024-09-14 5:17 ` [PATCH v2 04/22] dt-bindings: pinctrl: apple,pinctrl: Add A7-A11 compatibles Nick Chan
2024-09-14 5:17 ` [PATCH v2 05/22] dt-bindings: arm: apple: Add A7 devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 06/22] dt-bindings: arm: apple: Add A8 devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 07/22] dt-bindings: arm: apple: Add A8X devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 08/22] dt-bindings: arm: apple: Add A9 devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 09/22] dt-bindings: arm: apple: Add A9X devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 10/22] dt-bindings: arm: apple: Add A10 devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 11/22] dt-bindings: arm: apple: Add A10X devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 12/22] dt-bindings: arm: apple: Add A11 devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 13/22] arm64: dts: apple: Add A7 devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 14/22] arm64: dts: apple: Add A8 devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 15/22] arm64: dts: apple: Add A8X devices Nick Chan
2024-09-14 21:02 ` Ivaylo Ivanov
2024-09-15 2:21 ` Nick Chan
2024-09-14 5:17 ` [PATCH v2 16/22] arm64: dts: apple: Add A9 devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 17/22] arm64: dts: apple: Add A9X devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 18/22] arm64: dts: apple: Add A10 devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 19/22] arm64: dts: apple: Add A10X devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 20/22] arm64: dts: apple: Add A11 devices Nick Chan
2024-09-14 5:17 ` [PATCH v2 21/22] arm64: dts: apple: t8010: Add cpufreq nodes Nick Chan
2024-09-14 5:17 ` [PATCH v2 22/22] arm64: Kconfig: Update help text for CONFIG_ARCH_APPLE Nick Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ebf5258-b55d-4010-aa94-d5bab1f93bb5@gmail.com \
--to=towinchenmi@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=kettenis@openbsd.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lpieralisi@kernel.org \
--cc=marcan@marcan.st \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).