From: Niyas Sait <niyas.sait@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, rafael@kernel.org
Subject: Re: [PATCH RFC 2/3] pinconf-generic: add pull up and pull down config with resistance
Date: Fri, 11 Nov 2022 09:22:08 +0000 [thread overview]
Message-ID: <2ec52e22-2e58-4de1-723d-7e55cb183769@linaro.org> (raw)
In-Reply-To: <CACRpkdZCrdHttbk7j2reBgYPfYqYr1GTMNortcE9sQV4GdMwhw@mail.gmail.com>
That's good to know. I wasn't sure and didn't want to break any existing
interface. I will drop the new types and add the comment to clarify the use.
On 11/11/2022 09:17, Linus Walleij wrote:
> When I designed this, I definitely intended for the argument to
> PIN_CONFIG_BIAS_PULL_DOWN to be used for this, so I would just:
>
> - Use PIN_CONFIG_BIAS_PULL_DOWN
> - Augment the comment to say:
> "If the argument is != 0 pull-down is enabled, the value is interpreted by
> the driver and can be custom or an SI unit such as ohms".
next prev parent reply other threads:[~2022-11-11 9:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 19:12 [PATCH RFC 0/3] pinctrl: add ACPI support to pin controller Niyas Sait
2022-11-10 19:12 ` [PATCH RFC 1/3] pinctrl: add support for acpi PinGroup resource Niyas Sait
2022-11-11 12:12 ` Mika Westerberg
2022-11-15 18:10 ` Niyas Sait
2022-11-10 19:12 ` [PATCH RFC 2/3] pinconf-generic: add pull up and pull down config with resistance Niyas Sait
2022-11-10 20:17 ` Andy Shevchenko
2022-11-11 7:23 ` Niyas Sait
2022-11-11 9:17 ` Linus Walleij
2022-11-11 9:22 ` Niyas Sait [this message]
2022-11-10 19:12 ` [PATCH RFC 3/3] pinctrl: add support for acpi pin function and config resources Niyas Sait
2022-11-11 12:24 ` Mika Westerberg
2022-11-15 18:14 ` Niyas Sait
2022-11-10 20:14 ` [PATCH RFC 0/3] pinctrl: add ACPI support to pin controller Andy Shevchenko
2022-11-10 20:23 ` Andy Shevchenko
2022-11-11 7:15 ` Niyas Sait
2022-11-11 7:17 ` Niyas Sait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ec52e22-2e58-4de1-723d-7e55cb183769@linaro.org \
--to=niyas.sait@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).