From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Andrei Lalaev <andrey.lalaev@gmail.com>,
Andre Przywara <andre.przywara@arm.com>,
Yangtao Li <frank@allwinnertech.com>,
Maxime Ripard <mripard@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: wens@csie.org, samuel@sholland.org, linux-gpio@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: Re: Re: [PATCH] pinctrl: sunxi: sunxi_pconf_set: use correct offset
Date: Wed, 15 Jun 2022 17:56:08 +0200 [thread overview]
Message-ID: <3106779.5fSG56mABF@kista> (raw)
In-Reply-To: <CACRpkdbfJhwee-dnkhE3=ijiLcSx8seVxoKPzyZ_n7bz=TkU7w@mail.gmail.com>
Dne sreda, 15. junij 2022 ob 15:17:55 CEST je Linus Walleij napisal(a):
> On Wed, May 25, 2022 at 9:08 PM Andrei Lalaev <andrey.lalaev@gmail.com>
wrote:
>
> > Some Allwinner SoCs have 2 pinctrls (PIO and R_PIO).
> > Previous implementation used absolute pin numbering and it was incorrect
> > for R_PIO pinctrl.
> > It's necessary to take into account the base pin number.
> >
> > Fixes: 90be64e27621 ("pinctrl: sunxi: implement pin_config_set")
> > Signed-off-by: Andrei Lalaev <andrey.lalaev@gmail.com>
>
> It fixes a patch by Maxime so want Maxime to ACK this if it should be
> applied. Paging Andre and Yangtao too, would be sad if we don't apply it
> if it is a necessary fix.
From what I can see, this fixes makes code consistent with pattern in other
functions, so I think it's good.
Best regards,
Jernej
next prev parent reply other threads:[~2022-06-15 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 19:04 [PATCH] pinctrl: sunxi: sunxi_pconf_set: use correct offset Andrei Lalaev
2022-05-26 20:52 ` Jernej Škrabec
2022-06-15 18:06 ` Andrei Lalaev
2022-06-15 13:17 ` Linus Walleij
2022-06-15 15:56 ` Jernej Škrabec [this message]
2022-06-17 4:32 ` Samuel Holland
2022-06-27 9:27 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3106779.5fSG56mABF@kista \
--to=jernej.skrabec@gmail.com \
--cc=andre.przywara@arm.com \
--cc=andrey.lalaev@gmail.com \
--cc=frank@allwinnertech.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).