From: Keerthy <j-keerthy@ti.com>
To: linus.walleij@linaro.org
Cc: t-kristo@ti.com, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, fcooper@ti.com, s-anna@ti.com,
nsekhar@ti.com
Subject: Re: [PATCH v2 2/3] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function
Date: Wed, 2 Aug 2017 16:29:16 +0530 [thread overview]
Message-ID: <32ca2ace-bca3-4819-d3fb-10331cd0213c@ti.com> (raw)
In-Reply-To: <1500543738-9696-3-git-send-email-j-keerthy@ti.com>
On Thursday 20 July 2017 03:12 PM, Keerthy wrote:
> Currently davinci_gpio_irq_setup return value is ignored. Handle the
> return value appropriately.
Linus,
Any comments on this? Sorry if i pinged too soon. The rest 2 of this
series were pulled by you. So just wanted to check on this one if you
had specific comments.
Regards,
Keerthy
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/gpio/gpio-davinci.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 27499ec..d6fb1ce 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -237,7 +237,10 @@ static int davinci_gpio_probe(struct platform_device *pdev)
> goto err;
>
> platform_set_drvdata(pdev, chips);
> - davinci_gpio_irq_setup(pdev);
> + ret = davinci_gpio_irq_setup(pdev);
> + if (ret)
> + goto err;
> +
> return 0;
>
> err:
>
next prev parent reply other threads:[~2017-08-02 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 9:42 [PATCH v2 0/3] gpio: davinci: Add missing return checks Keerthy
2017-07-20 9:42 ` [PATCH v2 1/3] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data Keerthy
2017-08-02 9:23 ` Linus Walleij
2017-07-20 9:42 ` [PATCH v2 2/3] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Keerthy
2017-08-02 10:59 ` Keerthy [this message]
2017-08-07 12:12 ` Linus Walleij
2017-08-07 12:38 ` Keerthy
2017-08-07 13:33 ` Linus Walleij
2017-07-20 9:42 ` [PATCH v2 3/3] gpio: davinci: Convert prinkt to dev_err Keerthy
2017-08-02 9:25 ` Linus Walleij
2017-07-20 9:43 ` [PATCH v2 0/3] gpio: davinci: Add missing return checks Keerthy
2017-07-20 19:57 ` Suman Anna
2017-07-31 11:52 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32ca2ace-bca3-4819-d3fb-10331cd0213c@ti.com \
--to=j-keerthy@ti.com \
--cc=fcooper@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=s-anna@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).