From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2] sh-pfc: add R8A7794 PFC support
Date: Mon, 16 Feb 2015 21:41:31 +0200
Message-ID: <33139732.2SupcF0KCS@avalon>
References: <5262485.fuAdzVmykl@wasted.cogentembedded.com> <1974835.KMEIIiPVsr@avalon> <CAMuHMdX-U-JdWhsg9qiA8okKOjQxqLmusah3kcJbzSjzvhbmnA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Return-path: <linux-sh-owner@vger.kernel.org>
In-Reply-To: <CAMuHMdX-U-JdWhsg9qiA8okKOjQxqLmusah3kcJbzSjzvhbmnA@mail.gmail.com>
Sender: linux-sh-owner@vger.kernel.org
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, Linus Walleij <linus.walleij@linaro.org>, Linux-sh list <linux-sh@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
List-Id: linux-gpio@vger.kernel.org

Hi Geert,

On Monday 16 February 2015 09:57:09 Geert Uytterhoeven wrote:
> On Sun, Feb 15, 2015 at 5:06 PM, Laurent Pinchart wrote:
> >> --- /dev/null
> >> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
> >> @@ -0,0 +1,3989 @@
> >> +/*
> >> + * r8a7794 processor support - PFC hardware block.
> >> + *
> >> + * Copyright (C) 2014 Renesas Electronics Corporation
> >> + * Copyright (C) 2015 Renesas Solutions Corp.
> >> + * Copyright (C) 2015 Cogent  Embedded, Inc.,
> >> <source@cogentembedded.com>
> >> + *
> >> + * This program is free software; you can redistribute it and/or modify
> >> + * it under the terms of the GNU General Public License version 2
> >> + * as published by the Free Software Foundation.
> >> + */
> >> +
> >> +#include <linux/kernel.h>
> >> +#include <linux/platform_data/gpio-rcar.h>
> >> +
> >> +#include "core.h"
> >> +#include "sh_pfc.h"
> >> +
> >> +#define CPU_ALL_PORT(fn, sfx)                                           
> >>     \ +     PORT_GP_32(0, fn, sfx),                                     
> >>    \ +     PORT_GP_32(1, fn, sfx),                                      
> >>   \ +     PORT_GP_32(2, fn, sfx),                                       
> >>  \ +     PORT_GP_32(3, fn, sfx),                                        
> >> \ +     PORT_GP_32(4, fn, sfx),                                        
> >> \ +     PORT_GP_32(5, fn, sfx),                                        
> >> \ +     PORT_GP_32(6, fn, sfx)
> > 
> > If I'm not mistaken port GP1 has 26 pins only, GP5 28 pins and GP6 26
> > pins.
> 
> That's correct.
> 
> If that has to be reflected in the CPU_ALL_PORT() macro, a few existing pfc
> drivers should be modified, too:
>   - on r8a7790, port GP1 and GP2 have 30 pins only,
>   - on r8a7791, port GP1 has 26 pins only.

Done :-)

-- 
Regards,

Laurent Pinchart