linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "TY_Chang[張子逸]" <tychang@realtek.com>
To: Andy Shevchenko <andy@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] Add GPIO support for Realtek DHC(Digital Home Center) RTD SoCs.
Date: Fri, 1 Dec 2023 01:50:56 +0000	[thread overview]
Message-ID: <3482d87c4cd74363964d1d867e0c81cd@realtek.com> (raw)
In-Reply-To: <ZWCJkddstjpXTtQx@smile.fi.intel.com>

Hi Andy,

>
>On Fri, Nov 24, 2023 at 10:38:42AM +0100, Linus Walleij wrote:
>> On Thu, Nov 16, 2023 at 12:14 PM Tzuyi Chang <tychang@realtek.com>
>wrote:
>>
>> > This driver enables configuration of GPIO direction, GPIO values,
>> > GPIO debounce settings and handles GPIO interrupts.
>> >
>> > Signed-off-by: Tzuyi Chang <tychang@realtek.com>
>>
>> Apart from the missing kerneldoc that the autobuilder is complaining
>> about this looks good to me. If you fix the kerneldoc:
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
>I think I might have comments in the future.
>I haven't looked at the series due to noticing LKP complains.
>

I will fix the build warning in the next version.

Thanks,
Tzuyi Chang


  reply	other threads:[~2023-12-01  1:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 11:14 [PATCH v2 0/2] Add gpio driver support for Realtek DHC SoCs Tzuyi Chang
2023-11-16 11:14 ` [PATCH v2 1/2] dt-bindings: gpio: realtek: Add realtek,rtd-gpio Tzuyi Chang
2023-11-16 12:01   ` Krzysztof Kozlowski
2023-11-21  7:07     ` TY_Chang[張子逸]
2023-11-16 11:14 ` [PATCH v2 2/2] Add GPIO support for Realtek DHC(Digital Home Center) RTD SoCs Tzuyi Chang
2023-11-16 22:56   ` kernel test robot
2023-11-24  9:38   ` Linus Walleij
2023-11-24 11:31     ` Andy Shevchenko
2023-12-01  1:50       ` TY_Chang[張子逸] [this message]
2023-12-01  1:44     ` TY_Chang[張子逸]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3482d87c4cd74363964d1d867e0c81cd@realtek.com \
    --to=tychang@realtek.com \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).