From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-sh@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH/RFC 1/4] pinctrl: sh-pfc: Add PINMUX_SINGLE()
Date: Wed, 25 Nov 2015 02:49:55 +0200 [thread overview]
Message-ID: <3546719.xIF05iocVT@avalon> (raw)
In-Reply-To: <1445369195-25117-2-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Tuesday 20 October 2015 21:26:32 Geert Uytterhoeven wrote:
> Add a macro to describe a pinmux configuration for a single-function
> pin.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/pinctrl/sh-pfc/sh_pfc.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h
> b/drivers/pinctrl/sh-pfc/sh_pfc.h index 63e6cd050d0fb7d2..932fbef8bad400dd
> 100644
> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -277,6 +277,13 @@ struct sh_pfc_soc_info {
> PINMUX_DATA(fn##_MARK, FN_##ms, FN_##ipsr, FN_##fn)
>
> /*
> + * Describe a pinmux configuration for a single-function pin.
I would say "single-function pin with GPIO capability".
Apart from that,
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + * - fn: Function name
> + */
> +#define PINMUX_SINGLE(fn) \
> + PINMUX_DATA(fn##_MARK, FN_##fn)
> +
> +/*
> * GP port style (32 ports banks)
> */
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-11-25 0:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 19:26 [PATCH/RFC 0/4] pinctrl: sh-pfc: Add PINMUX_SINGLE() Geert Uytterhoeven
2015-10-20 19:26 ` [PATCH/RFC 1/4] " Geert Uytterhoeven
2015-11-25 0:49 ` Laurent Pinchart [this message]
2015-11-30 10:44 ` Geert Uytterhoeven
2015-10-20 19:26 ` [PATCH/RFC 2/4] pinctrl: sh-pfc: r8a7790: Use PINMUX_SINGLE() instead of raw PINMUX_DATA() Geert Uytterhoeven
2015-10-20 19:26 ` [PATCH/RFC 3/4] pinctrl: sh-pfc: r8a7791: " Geert Uytterhoeven
2015-10-20 19:26 ` [PATCH/RFC 4/4] pinctrl: sh-pfc: r8a7794: " Geert Uytterhoeven
2015-10-21 1:18 ` [PATCH/RFC 0/4] pinctrl: sh-pfc: Add PINMUX_SINGLE() Kuninori Morimoto
2015-10-27 10:20 ` Linus Walleij
2015-11-25 0:48 ` Laurent Pinchart
2015-11-25 10:14 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3546719.xIF05iocVT@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).