From: "Vesa Jääskeläinen" <dachaac@gmail.com>
To: Nava kishore Manne <nava.manne@xilinx.com>,
linus.walleij@linaro.org, gnurou@gmail.com,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Nava kishore Manne <navam@xilinx.com>
Subject: Re: [PATCH v3] gpio: Added zynq specific check for special pins on bank zero
Date: Sat, 24 Sep 2016 18:18:13 +0300 [thread overview]
Message-ID: <355c3a93-0f7d-adc1-224e-ac48afacbcb9@gmail.com> (raw)
In-Reply-To: <1474630018-9986-1-git-send-email-navam@xilinx.com>
On 23/09/2016 14.26, Nava kishore Manne wrote:
> From: Nava kishore Manne <nava.manne@xilinx.com>
>
> This patch adds zynq specific check for bank 0 pins 7 and 8
> are special and cannot be used as inputs
>
> Signed-off-by: Nava kishore Manne <navam@xilinx.com>
> Reported-by: Jonas Karlsson <Jonas.d.karlsson@gmail.com>
> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> ---
> Changes for v3:
> -Fixed some minor comments.
> Changes for v2:
> -Removed un-used quirks for zynqmp.
>
> drivers/gpio/gpio-zynq.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
> index e72794e..6b4d10d 100644
> --- a/drivers/gpio/gpio-zynq.c
> +++ b/drivers/gpio/gpio-zynq.c
> @@ -96,6 +96,9 @@
> /* GPIO upper 16 bit mask */
> #define ZYNQ_GPIO_UPPER_MASK 0xFFFF0000
>
> +/* For GPIO quirks */
> +#define ZYNQ_GPIO_QUIRK_FOO BIT(0)
Should this be a bit more descriptive than FOO?
prev parent reply other threads:[~2016-09-24 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 11:26 [PATCH v3] gpio: Added zynq specific check for special pins on bank zero Nava kishore Manne
2016-09-23 13:27 ` Linus Walleij
2016-09-24 15:18 ` Vesa Jääskeläinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=355c3a93-0f7d-adc1-224e-ac48afacbcb9@gmail.com \
--to=dachaac@gmail.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=navam@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).