From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-gpio@vger.kernel.org,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Thierry Reding <treding@nvidia.com>
Subject: [PATCH v2 0/6] pintrl: meson: add support for GPIO IRQs
Date: Fri, 12 May 2017 21:01:09 +0200 [thread overview]
Message-ID: <36164ed8-aa59-2a77-b7fc-9adce03a2fc1@gmail.com> (raw)
This patch series is partially based on a series Jerome Brunet
submitted about half a year ago. Due to open questions this series never
made it to mainline, see https://patchwork.kernel.org/patch/9384431/
This new attempt uses GPIOLIB_IRQCHIP resulting in less needed code.
Included is also support for using two parent IRQs in case
of IRQ_TYPE_EDGE_BOTH, like in the vendor driver.
Worth to be mentioned is also that I had to work around a strange
issue with spurious interrupts resulting in a deadlock.
The affected critical section in __setup_irq is executed with interrupts
disabled, nevertheless spurious GPIO IRQs result in a deadlock what
seems to indicate that they are handled on the same CPU.
I didn't find a better explanation than a possible HW flaw so far.
The series was successfully tested on a Odroid-C2, e.g. with removing
polling for SD card insertion/removal from the mmc driver.
Changes in v2:
- separate the GPIO IRQ controller from the pinctrl driver
- minor improvements to the GPIO IRQ controller
Heiner Kallweit (5):
pinctrl: meson: add interrupts to pinctrl data
pinctrl: meson: document GPIO IRQ DT binding
pinctrl: meson: add DT node for GPIO IRQ on Meson GX
pinctrl: meson: add DT node for GPIO IRQ on Meson 8 / 8b
pinctrl: meson: improve meson_get_bank and export it
pinctrl: meson: add support for GPIO interrupts
.../bindings/gpio/amlogic,meson-gpio-interrupt.txt | 30 ++
arch/arm/boot/dts/meson8.dtsi | 13 +
arch/arm/boot/dts/meson8b.dtsi | 13 +
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 13 +
drivers/pinctrl/Kconfig | 1 +
drivers/pinctrl/meson/Makefile | 2 +-
drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 22 +-
drivers/pinctrl/meson/pinctrl-meson-gxl.c | 20 +-
drivers/pinctrl/meson/pinctrl-meson-irq.c | 367 +++++++++++++++++++++
drivers/pinctrl/meson/pinctrl-meson.c | 67 ++--
drivers/pinctrl/meson/pinctrl-meson.h | 19 +-
drivers/pinctrl/meson/pinctrl-meson8.c | 20 +-
drivers/pinctrl/meson/pinctrl-meson8b.c | 32 +-
13 files changed, 538 insertions(+), 81 deletions(-)
create mode 100644 Documentation/devicetree/bindings/gpio/amlogic,meson-gpio-interrupt.txt
create mode 100644 drivers/pinctrl/meson/pinctrl-meson-irq.c
--
2.12.2
next reply other threads:[~2017-05-12 19:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 19:01 Heiner Kallweit [this message]
2017-05-12 19:13 ` [PATCH v2 1/6] pintrl: meson: add interrupts to pinctrl data Heiner Kallweit
2017-05-12 19:13 ` [PATCH v2 2/6] pintrl: meson: document GPIO IRQ DT binding Heiner Kallweit
2017-05-16 23:28 ` Jerome Brunet
2017-05-17 21:02 ` Heiner Kallweit
[not found] ` <ec9310f1-10eb-789f-e6f7-67e0340f4c64-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-23 8:35 ` Jerome Brunet
2017-05-12 19:13 ` [PATCH v2 3/6] pintrl: meson: add DT node for GPIO IRQ on Meson GX Heiner Kallweit
[not found] ` <36164ed8-aa59-2a77-b7fc-9adce03a2fc1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-12 19:13 ` [PATCH v2 4/6] pintrl: meson: add DT node for GPIO IRQ on Meson 8 / 8b Heiner Kallweit
2017-05-12 19:14 ` [PATCH v2 6/6] pintrl: meson: add support for GPIO interrupts Heiner Kallweit
2017-05-15 8:05 ` Neil Armstrong
2017-05-15 19:00 ` Heiner Kallweit
2017-05-16 7:54 ` Neil Armstrong
2017-05-16 18:31 ` Heiner Kallweit
[not found] ` <fbaf536e-3416-3c4a-4902-05b56783f9c2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-16 23:16 ` Jerome Brunet
2017-05-17 20:36 ` Heiner Kallweit
[not found] ` <3dccae17-f811-bc26-e125-7ff3f0bffa7d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-23 8:38 ` Jerome Brunet
2017-05-28 16:01 ` Heiner Kallweit
[not found] ` <dc23b800-fe69-8143-6367-d3cd801cd6db-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-16 23:07 ` Jerome Brunet
2017-05-17 20:20 ` Heiner Kallweit
2017-05-12 19:14 ` [PATCH v2 5/6] pintrl: meson: improve meson_get_bank and export it Heiner Kallweit
2017-05-14 10:19 ` [PATCH v2 0/6] pintrl: meson: add support for GPIO IRQs Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36164ed8-aa59-2a77-b7fc-9adce03a2fc1@gmail.com \
--to=hkallweit1@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).