From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, Jonas Jensen <jonas.jensen@gmail.com>
Subject: Re: [PATCH] gpio: moxart: fix build regression
Date: Thu, 07 Jan 2016 15:03:06 +0100 [thread overview]
Message-ID: <3740193.jff4NfDRv6@wuerfel> (raw)
In-Reply-To: <4110228.QqTjkKaKSX@wuerfel>
On Thursday 07 January 2016 14:55:34 Arnd Bergmann wrote:
> A cleanup patch replaced bgpio_chip with gpio_chip but missed
> two references to the bgpio_chip:
>
> drivers/gpio/gpio-moxart.c:60:19: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
> gc->bgpio_data = bgc->read_reg(bgc->reg_set);
> drivers/gpio/gpio-moxart.c:35:20: note: 'gc' declared here
> drivers/gpio/gpio-moxart.c:60:33: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
> gc->bgpio_data = bgc->read_reg(bgc->reg_set);
>
> This adds the missing change.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> ---
Adding Jonas to Cc, sorry for forgetting him first.
> diff --git a/drivers/gpio/gpio-moxart.c b/drivers/gpio/gpio-moxart.c
> index 71c13c4e12b5..ca604538ebf7 100644
> --- a/drivers/gpio/gpio-moxart.c
> +++ b/drivers/gpio/gpio-moxart.c
> @@ -57,7 +57,7 @@ static int moxart_gpio_probe(struct platform_device *pdev)
> gc->label = "moxart-gpio";
> gc->request = gpiochip_generic_request;
> gc->free = gpiochip_generic_free;
> - gc->bgpio_data = bgc->read_reg(bgc->reg_set);
> + gc->bgpio_data = gc->read_reg(gc->reg_set);
> gc->base = 0;
> gc->ngpio = 32;
> gc->parent = dev;
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-01-07 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 13:55 [PATCH] gpio: moxart: fix build regression Arnd Bergmann
2016-01-07 14:03 ` Arnd Bergmann [this message]
2016-01-07 15:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3740193.jff4NfDRv6@wuerfel \
--to=arnd@arndb.de \
--cc=jonas.jensen@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).