From: Johan Korsnes <johan.korsnes@remarkable.no>
To: Linus Walleij <linus.walleij@linaro.org>,
Bough Chen <haibo.chen@nxp.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
imx@lists.linux.dev
Cc: linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3 2/2] gpio: vf610: Switch to gpio-mmio
Date: Sun, 23 Feb 2025 14:57:02 +0100 [thread overview]
Message-ID: <37e3fbc9-87c2-49d4-bf32-e4c5906cdad6@remarkable.no> (raw)
In-Reply-To: <20250219-vf610-mmio-v3-2-588b64f0b689@linaro.org>
On 2/19/25 10:04 PM, Linus Walleij wrote:
> After adding a pinctrl flag to gpio-mmio we can use it
> for driving gpio-vf610.
>
> The existing code has the same semantics and the generic
> gpio-mmio, including reading from the data out register
> when the direction is set to input, and it can also handle
> the absence of the direction register better than the
> current driver: we get the direction from the shadow
> direction registers in gpio-mmio instead.
>
> Since gpio-mmio has an internal spinlock we can drop the
> direction-protecting spinlock from the driver.
>
Hi,
Could the following headers be dropped?
#include <linux/pinctrl/consumer.h>
#include <linux/spinlock.h>
Kind regards,
Johan
next prev parent reply other threads:[~2025-02-23 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 21:04 [PATCH v3 0/2] gpio-mmio: Extend to handle pinctrl back-ends Linus Walleij
2025-02-19 21:04 ` [PATCH v3 1/2] gpio: mmio: Add flag for calling pinctrl back-end Linus Walleij
2025-02-24 20:32 ` Andy Shevchenko
2025-02-19 21:04 ` [PATCH v3 2/2] gpio: vf610: Switch to gpio-mmio Linus Walleij
2025-02-21 3:57 ` Bough Chen
2025-02-21 10:16 ` Bartosz Golaszewski
2025-02-21 10:54 ` Bough Chen
2025-02-23 13:57 ` Johan Korsnes [this message]
2025-02-24 19:50 ` [PATCH v3 0/2] gpio-mmio: Extend to handle pinctrl back-ends Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37e3fbc9-87c2-49d4-bf32-e4c5906cdad6@remarkable.no \
--to=johan.korsnes@remarkable.no \
--cc=brgl@bgdev.pl \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).