From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Nickolay Goppen <setotau@mainlining.org>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org,
Nickolay Goppen <setotau@yandex.ru>
Subject: Re: [PATCH v5 1/3] pinctrl: qcom: lpass-lpi: Add ability to use custom pin offsets
Date: Thu, 4 Sep 2025 11:05:08 +0200 [thread overview]
Message-ID: <3a00018f-7573-43c6-867f-eff4041c0ca7@oss.qualcomm.com> (raw)
In-Reply-To: <20250903-sdm660-lpass-lpi-v5-1-fe171098b6a1@mainlining.org>
On 9/3/25 3:39 PM, Nickolay Goppen wrote:
> By default pin_offset is calculated by formula: LPI_TLMM_REG_OFFSET * pin_id.
> However not all platforms are using this pin_offset formula (e.g. SDM660 LPASS
> LPI uses a predefined array of offsets [1]), so extend lpi_pingroup struct
> with pin_offset field, introduce extended LPI_PINGROUP_OFFSET macro with
> pin_offet field and introduce LPI_FLAG_USE_PREDEFINED_PIN_OFFSET flag.
> This adds an ability to use predefined offset for pin if it exists.
>
> [1] https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/LA.UM.7.2.c27-07400-sdm660.0/drivers/pinctrl/qcom/pinctrl-lpi.c#L107
>
> Signed-off-by: Nickolay Goppen <setotau@mainlining.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2025-09-04 9:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 13:39 [PATCH v5 0/3] Add SDM660 LPASS LPI TLMM Nickolay Goppen
2025-09-03 13:39 ` [PATCH v5 1/3] pinctrl: qcom: lpass-lpi: Add ability to use custom pin offsets Nickolay Goppen
2025-09-04 9:05 ` Konrad Dybcio [this message]
2025-09-03 13:39 ` [PATCH v5 2/3] dt-bindings: pinctrl: qcom: Add SDM660 LPI pinctrl Nickolay Goppen
2025-09-03 14:14 ` Krzysztof Kozlowski
2025-09-03 13:39 ` [PATCH v5 3/3] pinctrl: qcom: Add SDM660 LPASS LPI TLMM Nickolay Goppen
2025-09-03 21:23 ` Richard Acayan
2025-09-04 9:05 ` Konrad Dybcio
2025-09-08 12:18 ` [PATCH v5 0/3] " Linus Walleij
2025-09-08 12:19 ` Nickolay Goppen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a00018f-7573-43c6-867f-eff4041c0ca7@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@mainlining.org \
--cc=robh@kernel.org \
--cc=setotau@mainlining.org \
--cc=setotau@yandex.ru \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox