From: Krzysztof Kozlowski <krzk@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"biju.das.au" <biju.das.au@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v4 1/7] dt-bindings: pinctrl: renesas: Add alpha-numerical port support for RZ/V2H
Date: Tue, 17 Dec 2024 10:44:48 +0100 [thread overview]
Message-ID: <3a66447f-005c-4c64-a8de-6a7a535abe90@kernel.org> (raw)
In-Reply-To: <TY3PR01MB1134679D57AA7DDC185BCD3E286042@TY3PR01MB11346.jpnprd01.prod.outlook.com>
On 17/12/2024 10:19, Biju Das wrote:
>>>>>> Calling it a binding makes it immutable and gives us, DT
>>>>>> maintainers, more work, so really no benefits at all.
>>>>>
>>>>>>
>>>>>> I guess other DT maintainers will ack it, I prefer to reduce number of headers.
>>>>>
>>>>> DT describes hardware. The port names are alpha numeric on hardware manual.
>>>>
>>>> We talk about binding, not DT.
>>>
>>> Bu the definitions are part of bindings just like Commit "997daa8de64ccbb".
>>
>> You made them part of bindings, but this is invalid as argument. How is this anyhow related? How is
>> "DT describes hardware" part of binding?
>>
>> You said "DT describes hardware", but we do not talk here about DT, do we? We talk about binding.
>
> OK.
>
>> I am not going to keep reading all the external references you keep bringing or discussing why someone
>> else did something. This patch must be logical and correct on its own, not because someone else made
>> something somewhere.
>
> OK. According to me this patch is correct. It is for DT user and it described clearly in commit message
So you repeat first point which I objected in the first place. If this
is for DT, then this is not a binding and does not deserve header.
>
> "RZ/V2H has ports P0-P9 and PA-PB. Add support for defining alpha-numerical
> ports in DT using RZV2H_* macros."
I read it, I objected to it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-17 9:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 19:53 [PATCH v4 0/7] Add RZ/G3E pinctrl support Biju Das
2024-12-16 19:53 ` [PATCH v4 1/7] dt-bindings: pinctrl: renesas: Add alpha-numerical port support for RZ/V2H Biju Das
2024-12-17 6:31 ` Krzysztof Kozlowski
2024-12-17 7:29 ` Biju Das
2024-12-17 7:50 ` Krzysztof Kozlowski
2024-12-17 8:49 ` Biju Das
2024-12-17 8:59 ` Krzysztof Kozlowski
2024-12-17 9:19 ` Biju Das
2024-12-17 9:44 ` Krzysztof Kozlowski [this message]
2024-12-17 9:52 ` Biju Das
2024-12-17 11:58 ` Rob Herring
2024-12-17 12:33 ` Biju Das
2024-12-18 19:22 ` Rob Herring
2024-12-18 19:24 ` Rob Herring (Arm)
2025-01-03 18:43 ` Geert Uytterhoeven
2025-01-07 11:16 ` Biju Das
2024-12-16 19:53 ` [PATCH v4 2/7] dt-bindings: pinctrl: renesas: Document RZ/G3E SoC Biju Das
2025-01-03 18:45 ` Geert Uytterhoeven
2025-01-07 11:15 ` Biju Das
2024-12-16 19:53 ` [PATCH v4 3/7] pinctrl: renesas: rzg2l: Update r9a09g057_variable_pin_cfg table Biju Das
2025-01-03 18:46 ` Geert Uytterhoeven
2024-12-16 19:53 ` [PATCH v4 4/7] pinctrl: renesas: rzg2l: Add support for RZ/G3E SoC Biju Das
2025-01-03 18:47 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a66447f-005c-4c64-a8de-6a7a535abe90@kernel.org \
--to=krzk@kernel.org \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox