Re: [PATCH RFC 0/2] pinctrl: bcm2835: Implement pin_conf_get

[Florian Fainelli <florian.fainelli@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]

On 2/25/24 02:01, Stefan Wahren wrote:
> Hi Florian,
> 
> Am 07.02.24 um 19:22 schrieb Florian Fainelli:
>> On 2/7/24 03:33, Stefan Wahren wrote:
>>> Hi Linus,
>>>
>>> Am 07.02.24 um 11:56 schrieb Linus Walleij:
>>>> On Sun, Feb 4, 2024 at 5:59 PM Stefan Wahren <wahrenst@gmx.net> wrote:
>>>>
>>>>> For years, the Raspberry Pi users relied on userspace programs to read
>>>>> the pin configuration. In the meantime, it has become apparent that
>>>>> this
>>>>> approach has reached its limits for various reasons.
>>>>>
>>>>> This patch series now attempts to improve the debugging
>>>>> possibilities on
>>>>> the kernel side in order to reduce the dependency on these userspace
>>>>> programs.
>>>>>
>>>>> Stefan Wahren (2):
>>>>>    pinctrl: bcm2835: Implement bcm2835_pinconf_get
>>>>>    pinctrl: bcm2835: Implement bcm2711_pinconf_get
>>>> I don't see any problems with this, can I just apply the patches or
>>>> do you
>>>> want to first resend them as non-RFC?
>>> since the second patch hasn't been tested with BCM7211, it would be nice
>>> to get a feedback from Florian or someone else with this hardware?
>>
>> Give me a few days to get there and I will run a test.
> 
> is there any chance to test with BCM7211?

Sorry about the delay, I just gave those patches a try although I am not 
sure where I should be seeing the reporting about being configured as 
pull up/down? Is this supposed to be visible under 
/sys/kernel/debug/pinctrl/*.gpio-pinctrl-bcm2711/pins?

Checking the datasheet for 2711/7211 we advertise 50kOhms internal pull 
ups/downs for all GPIO pins, so we might need to make the resistor value 
different based upon the board/SoC maybe.
-- 
Florian


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]