From: Krzysztof Kozlowski <krzk@kernel.org>
To: Prabhakar <prabhakar.csengg@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 11/15] dt-bindings: pinctrl: renesas: Document RZ/V2N SoC
Date: Thu, 27 Mar 2025 08:48:22 +0100 [thread overview]
Message-ID: <3d88eee6-1401-4ffc-85bb-3ea91f28d186@kernel.org> (raw)
In-Reply-To: <20250326143945.82142-12-prabhakar.mahadev-lad.rj@bp.renesas.com>
On 26/03/2025 15:39, Prabhakar wrote:
> +#define RZV2N_P3 3
> +#define RZV2N_P4 4
> +#define RZV2N_P5 5
> +#define RZV2N_P6 6
> +#define RZV2N_P7 7
> +#define RZV2N_P8 8
> +#define RZV2N_P9 9
> +#define RZV2N_PA 10
> +#define RZV2N_PB 11
Same comments as before - not useful to repeat the name.
It is the third patch in this patchset, which receives exactly the same
comments as given before.
I expect that given feedback somehow stays within group of contributions
or company in form of internal knowledge. Or just read other people's
patchset to learn from them and do not make the same mistakes.
> +
> +#define RZV2N_PORT_PINMUX(b, p, f) RZG2L_PORT_PINMUX(RZV2N_P##b, p, f)
> +#define RZV2N_GPIO(port, pin) RZG2L_GPIO(RZV2N_P##port, pin)
Not a binding. If you claim otherwise, point me to the line of driver
code using this binding.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-27 7:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 14:39 [PATCH 00/15] Add support for Renesas RZ/V2N SoC and EVK Prabhakar
2025-03-26 14:39 ` [PATCH 01/15] dt-bindings: soc: renesas: Document Renesas RZ/V2N SoC variants Prabhakar
2025-03-26 14:39 ` [PATCH 02/15] dt-bindings: soc: renesas: Document RZ/V2N EVK board Prabhakar
2025-03-27 7:41 ` Krzysztof Kozlowski
2025-03-28 14:47 ` Lad, Prabhakar
2025-03-26 14:39 ` [PATCH 03/15] soc: renesas: Add config option for RZ/V2N (R9A09G056) SoC Prabhakar
2025-03-26 14:39 ` [PATCH 04/15] dt-bindings: soc: renesas: Document SYS for RZ/V2N SoC Prabhakar
2025-03-31 14:21 ` Rob Herring (Arm)
2025-03-26 14:39 ` [PATCH 05/15] soc: renesas: sysc: Add SoC identification " Prabhakar
2025-03-26 14:39 ` [PATCH 06/15] dt-bindings: serial: renesas: Document RZ/V2N SCIF Prabhakar
2025-03-31 14:21 ` Rob Herring (Arm)
2025-03-26 14:39 ` [PATCH 07/15] dt-bindings: mmc: renesas,sdhi: Document RZ/V2N support Prabhakar
2025-03-31 14:22 ` Rob Herring (Arm)
2025-04-10 10:23 ` Geert Uytterhoeven
2025-03-26 14:39 ` [PATCH 08/15] dt-bindings: clock: renesas: Document RZ/V2N SoC CPG Prabhakar
2025-03-31 14:23 ` Rob Herring (Arm)
2025-03-26 14:39 ` [PATCH 09/15] clk: renesas: rzv2h-cpg: Sort compatible list based on SoC part number Prabhakar
2025-03-26 14:39 ` [PATCH 10/15] clk: renesas: rzv2h: Add support for RZ/V2N SoC Prabhakar
2025-03-26 14:39 ` [PATCH 11/15] dt-bindings: pinctrl: renesas: Document " Prabhakar
2025-03-27 7:48 ` Krzysztof Kozlowski [this message]
2025-03-28 15:05 ` Lad, Prabhakar
2025-03-26 14:39 ` [PATCH 12/15] pinctrl: renesas: rzg2l: Add support for " Prabhakar
2025-03-26 14:39 ` [PATCH 13/15] arm64: dts: renesas: Add initial SoC DTSI for RZ/V2N Prabhakar
2025-03-26 14:39 ` [PATCH 14/15] arm64: dts: renesas: Add initial device tree for RZ/V2N EVK Prabhakar
2025-03-27 7:43 ` Krzysztof Kozlowski
2025-03-28 15:06 ` Lad, Prabhakar
2025-03-26 14:39 ` [PATCH 15/15] arm64: defconfig: Enable Renesas RZ/V2N SoC Prabhakar
2025-03-27 7:43 ` Krzysztof Kozlowski
2025-03-27 8:55 ` Geert Uytterhoeven
2025-03-27 9:08 ` Geert Uytterhoeven
2025-03-27 14:00 ` Krzysztof Kozlowski
2025-03-27 12:27 ` Wolfram Sang
2025-03-27 14:22 ` Krzysztof Kozlowski
2025-03-27 16:44 ` Wolfram Sang
2025-03-28 7:44 ` Krzysztof Kozlowski
2025-03-28 11:36 ` Wolfram Sang
2025-03-28 15:09 ` Lad, Prabhakar
2025-03-26 19:11 ` [PATCH 00/15] Add support for Renesas RZ/V2N SoC and EVK Rob Herring (Arm)
2025-03-26 19:21 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d88eee6-1401-4ffc-85bb-3ea91f28d186@kernel.org \
--to=krzk@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@baylibre.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).