public inbox for linux-gpio@vger.kernel.org
 help / color / mirror / Atom feed
From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Frieder Schrempf <frieder@fris.de>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh@kernel.org>, Stefan Agner <stefan@agner.ch>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 3/7] dt-bindings: gpio: vf610: Allow gpio-line-names to be set
Date: Wed, 3 Jul 2024 09:43:26 +0200	[thread overview]
Message-ID: <3dda06a0-dd5b-4264-a142-562fa7bab3eb@kontron.de> (raw)
In-Reply-To: <26ad845a-3fde-47f0-8541-fa8c751530b2@kernel.org>

Hi Krzysztof,

thanks for reviewing!

On 02.07.24 4:23 PM, Krzysztof Kozlowski wrote:
> On 02/07/2024 12:31, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> Describe common "gpio-line-names" property to fix dtbs_check warnings
>> like:
>>
>>   arch/arm64/boot/dts/freescale/imx93-kontron-bl-osm-s.dtb: gpio@43810000:
> 
> There is no such file. You cannot use future work as reason for a
> warning. Simply such warning does not exist at this point and
> introducing warnings knowingly is also not correct.

Ok, I will change the commit message and not mention the warning.

> 
>>     'gpio-line-names' does not match any of the regexes: '^.+-hog(-[0-9]+)?$', 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>> ---
>>  Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
>> index a27f929502575..7230ba1a386ae 100644
>> --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
>> @@ -50,6 +50,7 @@ properties:
>>      const: 2
>>  
>>    gpio-controller: true
>> +  gpio-line-names: true
> 
> maxItems are not known?

I will set "minItems: 1" and "maxItems: 32" as this is the proper range
for the number of values.

Thanks
Frieder

  reply	other threads:[~2024-07-03  7:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 10:31 [PATCH 0/7] Add support for Kontron OSM-S i.MX93 SoM and carrier board Frieder Schrempf
2024-07-02 10:31 ` [PATCH 3/7] dt-bindings: gpio: vf610: Allow gpio-line-names to be set Frieder Schrempf
2024-07-02 14:23   ` Krzysztof Kozlowski
2024-07-03  7:43     ` Frieder Schrempf [this message]
2024-07-03  9:59 ` [PATCH 0/7] Add support for Kontron OSM-S i.MX93 SoM and carrier board Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3dda06a0-dd5b-4264-a142-562fa7bab3eb@kontron.de \
    --to=frieder.schrempf@kontron.de \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frieder@fris.de \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox