From: Christian Lamparter <chunkeey@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Asmaa Mnebhi <asmaa@nvidia.com>
Cc: andy.shevchenko@gmail.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Álvaro Fernández Rojas" <noltari@gmail.com>
Subject: Re: [PATCH v4] gpio: mmio: handle "ngpios" properly in bgpio_init()
Date: Sun, 16 Jul 2023 14:58:19 +0200 [thread overview]
Message-ID: <3e99caed-13bb-204c-4458-e0670fa9e8c9@gmail.com> (raw)
In-Reply-To: <CACRpkdZoVo-6BMYcuike2eC85ZGpP93_4WQVLTfjRAa1ho5xhg@mail.gmail.com>
On 7/16/23 09:42, Linus Walleij wrote:
> On Mon, Mar 6, 2023 at 10:12 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:
>
>> bgpio_init() uses "sz" argument to populate ngpio, which is not
>> accurate. Instead, read the "ngpios" property from the DT and if it
>> doesn't exist, use the "sz" argument. With this change, drivers no
>> longer need to overwrite the ngpio variable after calling bgpio_init().
>>
>> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thank you!
For context:
<https://patchwork.kernel.org/project/linux-arm-kernel/patch/535f785bf6116c0fb6f46afbb77e6d4bd3ef5f60.1462543458.git.chunkeey@googlemail.com/>
Regards,
Christian
prev parent reply other threads:[~2023-07-16 12:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 21:12 [PATCH v4] gpio: mmio: handle "ngpios" properly in bgpio_init() Asmaa Mnebhi
2023-03-06 22:37 ` andy.shevchenko
2023-03-06 22:39 ` Asmaa Mnebhi
2023-07-10 17:26 ` Asmaa Mnebhi
2023-07-10 19:10 ` Bartosz Golaszewski
2023-07-16 7:42 ` Linus Walleij
2023-07-16 12:58 ` Christian Lamparter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e99caed-13bb-204c-4458-e0670fa9e8c9@gmail.com \
--to=chunkeey@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=asmaa@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noltari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).