From: Neil Armstrong <neil.armstrong@linaro.org>
To: Da Xue <da@libre.computer>,
Linus Walleij <linus.walleij@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: meson-g12a: add g12b pwm groups
Date: Mon, 23 Jun 2025 09:41:03 +0200 [thread overview]
Message-ID: <3f335e16-8528-422a-a73e-efa06e68851c@linaro.org> (raw)
In-Reply-To: <20250619022337.43900-1-da@libre.computer>
On 19/06/2025 04:23, Da Xue wrote:
> g12b and sm1 have additional pwm pinmuxes for b, c, and d
>
> Signed-off-by: Da Xue <da@libre.computer>
> ---
> drivers/pinctrl/meson/pinctrl-meson-g12a.c | 22 +++++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-g12a.c b/drivers/pinctrl/meson/pinctrl-meson-g12a.c
> index e2788bfc5874..8b9130c6e170 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-g12a.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-g12a.c
> @@ -270,15 +270,21 @@ static const unsigned int pwm_a_pins[] = { GPIOX_6 };
> /* pwm_b */
> static const unsigned int pwm_b_x7_pins[] = { GPIOX_7 };
> static const unsigned int pwm_b_x19_pins[] = { GPIOX_19 };
> +static const unsigned int pwm_b_z0_pins[] = { GPIOZ_0 };
> +static const unsigned int pwm_b_z13_pins[] = { GPIOZ_13 };
> +static const unsigned int pwm_b_h_pins[] = { GPIOH_7 };
>
> /* pwm_c */
> static const unsigned int pwm_c_c_pins[] = { GPIOC_4 };
> static const unsigned int pwm_c_x5_pins[] = { GPIOX_5 };
> static const unsigned int pwm_c_x8_pins[] = { GPIOX_8 };
> +static const unsigned int pwm_c_z_pins[] = { GPIOZ_1 };
>
> /* pwm_d */
> static const unsigned int pwm_d_x3_pins[] = { GPIOX_3 };
> static const unsigned int pwm_d_x6_pins[] = { GPIOX_6 };
> +static const unsigned int pwm_d_z_pins[] = { GPIOZ_2 };
> +static const unsigned int pwm_d_a_pins[] = { GPIOA_4 };
>
> /* pwm_e */
> static const unsigned int pwm_e_pins[] = { GPIOX_16 };
> @@ -649,12 +655,22 @@ static const struct meson_pmx_group meson_g12a_periphs_groups[] = {
> GROUP(pwm_a, 1),
> GROUP(pwm_b_x7, 4),
> GROUP(pwm_b_x19, 1),
> + GROUP(pwm_b_z0, 5),
> + GROUP(pwm_b_z13, 5),
> + GROUP(pwm_b_h, 5),
> GROUP(pwm_c_x5, 4),
> GROUP(pwm_c_x8, 5),
> + GROUP(pwm_c_c, 5),
> + GROUP(pwm_c_z, 5),
> + GROUP(pwm_d_z, 4),
> + GROUP(pwm_d_a, 3),
> GROUP(pwm_d_x3, 4),
> GROUP(pwm_d_x6, 4),
> GROUP(pwm_e, 1),
> + GROUP(pwm_f_a, 3),
> + GROUP(pwm_f_h, 4),
> GROUP(pwm_f_x, 1),
> + GROUP(pwm_f_z, 5),
> GROUP(tsin_a_valid, 3),
> GROUP(tsin_a_sop, 3),
> GROUP(tsin_a_din0, 3),
> @@ -1058,15 +1074,15 @@ static const char * const pwm_a_groups[] = {
> };
>
> static const char * const pwm_b_groups[] = {
> - "pwm_b_x7", "pwm_b_x19",
> + "pwm_b_h", "pwm_b_x7", "pwm_b_x19", "pwm_b_z0", "pwm_b_z13"
> };
>
> static const char * const pwm_c_groups[] = {
> - "pwm_c_c", "pwm_c_x5", "pwm_c_x8",
> + "pwm_c_c", "pwm_c_x5", "pwm_c_x8", "pwm_c_z",
> };
>
> static const char * const pwm_d_groups[] = {
> - "pwm_d_x3", "pwm_d_x6",
> + "pwm_d_a", "pwm_d_x3", "pwm_d_x6", "pwm_d_z",
> };
>
> static const char * const pwm_e_groups[] = {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2025-06-23 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 2:23 [PATCH] pinctrl: meson-g12a: add g12b pwm groups Da Xue
2025-06-23 7:41 ` Neil Armstrong [this message]
2025-06-24 19:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f335e16-8528-422a-a73e-efa06e68851c@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=da@libre.computer \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox