linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: jimliu2 <jim.t90615@gmail.com>,
	JJLIU0@nuvoton.com, KWLIU@nuvoton.com, linus.walleij@linaro.org,
	brgl@bgdev.pl, robh+dt@kernel.org, avifishman70@gmail.com,
	tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com,
	yuenn@google.com, benjaminfair@google.com, CTCCHIEN@nuvoton.com
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v1 1/3] dts: add Nuvoton sgpio feature
Date: Fri, 11 Mar 2022 10:18:27 +0100	[thread overview]
Message-ID: <3f77c8c8-4bba-007b-fae9-5fb47f44719c@canonical.com> (raw)
In-Reply-To: <20220311060936.10663-2-JJLIU0@nuvoton.com>

On 11/03/2022 07:09, jimliu2 wrote:
> add Nuvoton sgpio feature
> 
> Signed-off-by: jimliu2 <JJLIU0@nuvoton.com>
> ---
>  arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
> index 3696980a3da1..58f4b463c745 100644
> --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
> +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
> @@ -329,6 +329,36 @@
>  				status = "disabled";
>  			};
>  
> +			sgpio1: sgpio@101000 {

Generic node name.

> +				clocks = <&clk NPCM7XX_CLK_APB3>;
> +				compatible = "nuvoton,npcm750-sgpio";
> +				interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> +				gpio-controller;
> +				#gpio-cells = <2>;
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&iox1_pins>;
> +				bus-frequency = <16000000>;
> +				nin_gpios = <64>;
> +				nout_gpios = <64>;
> +				reg = <0x101000 0x200>;

In each node first goes compatible, then reg.

Best regards,
Krzysztof

  reply	other threads:[~2022-03-11  9:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11  6:09 [PATCH v1 0/3]sgpio:nuvoton:add support for Nuvoton NPCM SoCs jimliu2
2022-03-11  6:09 ` [PATCH v1 1/3] dts: add Nuvoton sgpio feature jimliu2
2022-03-11  9:18   ` Krzysztof Kozlowski [this message]
2022-09-15  3:36     ` Jim Liu
2022-03-11  6:09 ` [PATCH v1 2/3] dt-bindings: support Nuvoton sgpio jimliu2
2022-03-11  9:25   ` Krzysztof Kozlowski
2022-03-11  6:09 ` [PATCH v1 3/3] gpio:gpio-npcm-sgpio: Add Nuvoton sgpio driver jimliu2
2022-04-05 15:00   ` Bartosz Golaszewski
2022-03-11  9:19 ` [PATCH v1 0/3]sgpio:nuvoton:add support for Nuvoton NPCM SoCs Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f77c8c8-4bba-007b-fae9-5fb47f44719c@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=CTCCHIEN@nuvoton.com \
    --cc=JJLIU0@nuvoton.com \
    --cc=KWLIU@nuvoton.com \
    --cc=avifishman70@gmail.com \
    --cc=benjaminfair@google.com \
    --cc=brgl@bgdev.pl \
    --cc=devicetree@vger.kernel.org \
    --cc=jim.t90615@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    --cc=tali.perry1@gmail.com \
    --cc=tmaimon77@gmail.com \
    --cc=venture@google.com \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).