From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Yixun Lan <dlan@gentoo.org>, Linus Walleij <linusw@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Troy Mitchell <troy.mitchell@linux.spacemit.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 3/3] pinctrl: spacemit: k3: adjust drive strength and schmitter trigger
Date: Mon, 22 Dec 2025 10:54:19 +0800 [thread overview]
Message-ID: <408BBF8CF676D97D+aUiy2w1iP1LJoUOW@kernel.org> (raw)
In-Reply-To: <20251220-02-k3-pinctrl-v1-3-f6f4aea60abf@gentoo.org>
Hi Yixun,
On Sat, Dec 20, 2025 at 06:14:55PM +0800, Yixun Lan wrote:
> K3 SoC expand drive strength to 4 bits which support even larger
> settings table comparing to old SoC generation. Also schmitter trigger
> setting is changed to 1 bit.
>
> Signed-off-by: Yixun Lan <dlan@gentoo.org>
> ---
> drivers/pinctrl/spacemit/pinctrl-k1.c | 163 ++++++++++++++++++++++++----------
> 1 file changed, 116 insertions(+), 47 deletions(-)
>
> diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c
> index 441817f539e3..8ca247fb8ba0 100644
> --- a/drivers/pinctrl/spacemit/pinctrl-k1.c
> +++ b/drivers/pinctrl/spacemit/pinctrl-k1.c
[...]
> - val = spacemit_get_driver_strength(type, drv_strength);
> + val = spacemit_get_driver_strength(type, dconf, drv_strength);
>
> - v &= ~PAD_DRIVE;
> - v |= FIELD_PREP(PAD_DRIVE, val);
> + v &= ~dconf->drive_mask;
> + v |= (arg << __ffs(dconf->drive_mask)) & dconf->drive_mask;
^^^^
use val here.
- Troy
next prev parent reply other threads:[~2025-12-22 2:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 10:14 [PATCH RFC 0/3] pinctrl: spacemit: add support for K3 SoC Yixun Lan
2025-12-20 10:14 ` [PATCH RFC 1/3] dt-bindings: pinctrl: spacemit: add K3 SoC support Yixun Lan
2025-12-24 2:56 ` Troy Mitchell
2025-12-24 3:04 ` Yixun Lan
2025-12-20 10:14 ` [PATCH RFC 2/3] pinctrl: spacemit: k3: add initial pin support Yixun Lan
2025-12-22 6:59 ` Troy Mitchell
2025-12-22 23:03 ` Yixun Lan
2025-12-23 1:04 ` Troy Mitchell
2025-12-20 10:14 ` [PATCH RFC 3/3] pinctrl: spacemit: k3: adjust drive strength and schmitter trigger Yixun Lan
2025-12-22 2:54 ` Troy Mitchell [this message]
2025-12-22 3:52 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=408BBF8CF676D97D+aUiy2w1iP1LJoUOW@kernel.org \
--to=troy.mitchell@linux.spacemit.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox