From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E925C433DB for ; Thu, 11 Feb 2021 07:37:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8A8464E3C for ; Thu, 11 Feb 2021 07:37:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbhBKHhh (ORCPT ); Thu, 11 Feb 2021 02:37:37 -0500 Received: from smtprelay0190.hostedemail.com ([216.40.44.190]:36094 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229674AbhBKHhe (ORCPT ); Thu, 11 Feb 2021 02:37:34 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 9C69A18224D6A; Thu, 11 Feb 2021 07:36:42 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: cough69_3f08c9527616 X-Filterd-Recvd-Size: 3608 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Thu, 11 Feb 2021 07:36:40 +0000 (UTC) Message-ID: <408ca31f3f43f4db40998f607f582aeb0ffbab1e.camel@perches.com> Subject: Re: [PATCH v4 1/2] pinctrl: use to octal permissions for debugfs files From: Joe Perches To: Drew Fustini , Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Lindgren , Andy Shevchenko , Alexandre Belloni , Geert Uytterhoeven , Pantelis Antoniou , Jason Kridner , Robert Nelson , Dan Carpenter Date: Wed, 10 Feb 2021 23:36:39 -0800 In-Reply-To: <20210210222851.232374-2-drew@beagleboard.org> References: <20210210222851.232374-1-drew@beagleboard.org> <20210210222851.232374-2-drew@beagleboard.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, 2021-02-10 at 14:28 -0800, Drew Fustini wrote: > Switch over pinctrl debugfs files to use octal permissions as they are > preferred over symbolic permissions. Refer to commit f90774e1fd27 > ("checkpatch: look for symbolic permissions and suggest octal instead"). > > Note: S_IFREG flag is added to the mode by __debugfs_create_file() > in fs/debugfs/inode.c > > Suggested-by: Andy Shevchenko > Signed-off-by: Drew Fustini > --- >  drivers/pinctrl/core.c | 6 +++--- >  drivers/pinctrl/pinconf.c | 4 ++-- >  drivers/pinctrl/pinmux.c | 4 ++-- >  3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c > index 3663d87f51a0..02f8710afb9c 100644 > --- a/drivers/pinctrl/core.c > +++ b/drivers/pinctrl/core.c > @@ -1914,11 +1914,11 @@ static void pinctrl_init_debugfs(void) >   return; >   } >   > > - debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO, > + debugfs_create_file("pinctrl-devices", 0444, >   debugfs_root, NULL, &pinctrl_devices_fops); > - debugfs_create_file("pinctrl-maps", S_IFREG | S_IRUGO, > + debugfs_create_file("pinctrl-maps", 0444, >   debugfs_root, NULL, &pinctrl_maps_fops); > - debugfs_create_file("pinctrl-handles", S_IFREG | S_IRUGO, > + debugfs_create_file("pinctrl-handles", 0444, >   debugfs_root, NULL, &pinctrl_fops); >  } Why aren't you also converting this block in the same file? @@ -1890,11 +1890,11 @@ static void pinctrl_init_device_debugfs(struct pinctrl_dev *pctldev) dev_name(pctldev->dev)); return; } - debugfs_create_file("pins", S_IFREG | S_IRUGO, + debugfs_create_file("pins", S_IFREG | 0444, device_root, pctldev, &pinctrl_pins_fops); - debugfs_create_file("pingroups", S_IFREG | S_IRUGO, + debugfs_create_file("pingroups", S_IFREG | 0444, device_root, pctldev, &pinctrl_groups_fops); - debugfs_create_file("gpio-ranges", S_IFREG | S_IRUGO, + debugfs_create_file("gpio-ranges", S_IFREG | 0444, device_root, pctldev, &pinctrl_gpioranges_fops); if (pctldev->desc->pmxops) pinmux_init_device_debugfs(device_root, pctldev);