From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-kernel@lists.codethink.co.uk
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Alessandro Rubini <rubini@unipv.it>
Subject: Re: [Linux-kernel] [PATCH] pinctrl: nomadik: fix warnings from unexported functions
Date: Wed, 8 Jun 2016 10:15:30 +0100 [thread overview]
Message-ID: <40be947d-89f6-2552-7bd2-91d16a378b2f@codethink.co.uk> (raw)
In-Reply-To: <d3712327-9d20-08ae-30b1-2b6d52e30420@codethink.co.uk>
On 07/06/16 18:30, Ben Dooks wrote:
> On 07/06/16 18:25, Ben Dooks wrote:
>> There are five functions in the driver that are defined but
>> only used locally. Make these static to avoid the following
>> warnings:
>>
>> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1036:6: warning: symbol 'nmk_gpio_clocks_enable' was not declared. Should it be static?
>> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1050:6: warning: symbol 'nmk_gpio_clocks_disable' was not declared. Should it be static?
>> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1073:6: warning: symbol 'nmk_gpio_wakeups_suspend' was not declared. Should it be static?
>> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1094:6: warning: symbol 'nmk_gpio_wakeups_resume' was not declared. Should it be static?
>> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1120:6: warning: symbol 'nmk_gpio_read_pull' was not declared. Should it be static?
>
> Apologies, wrong version of the patch without a typo fix in it.
Given these functions are not being used, should I just consider a
patch to remove these. If they are not being considered for future
development it might be a good idea?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genies
next prev parent reply other threads:[~2016-06-08 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 17:25 [PATCH] pinctrl: nomadik: fix warnings from unexported functions Ben Dooks
2016-06-07 17:30 ` Ben Dooks
2016-06-08 9:15 ` Ben Dooks [this message]
2016-06-08 12:14 ` [Linux-kernel] " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40be947d-89f6-2552-7bd2-91d16a378b2f@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=rubini@unipv.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).