From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Jonas Gorski <jonas.gorski@gmail.com>,
Necip Fazil Yildiran <fazilyildiran@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/12] Documentation: add BCM6328 pincontroller binding documentation
Date: Tue, 2 Mar 2021 17:53:56 +0100 [thread overview]
Message-ID: <418daebd-b35b-2edc-6f33-591bd97ba1f9@gmail.com> (raw)
In-Reply-To: <CACRpkdaN3pYMDiPkk109SwOKF56Oxe14_bC5edftGGG0PL7VsA@mail.gmail.com>
Hi Linus,
I think it's better if we leave the interrupts out for now.
It's not critical and it can be added later.
Best regards,
Álvaro.
El 02/03/2021 a las 16:23, Linus Walleij escribió:
> On Tue, Mar 2, 2021 at 3:57 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Thu, Feb 25, 2021 at 5:42 PM Álvaro Fernández Rojas
>> <noltari@gmail.com> wrote:
>>
>>> Add binding documentation for the pincontrol core found in BCM6328 SoCs.
>>>
>>> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
>>> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
>> (...)
>>> + interrupts-extended:
>>> + description:
>>> + One interrupt per each of the 4 GPIO ports supported by the controller,
>>> + sorted by port number ascending order.
>>> + minItems: 4
>>> + maxItems: 4
>>
>> I don't know if this is advisable, there are different ways
>> of specifying interrupts so this may become ambiguous,
>> I think Rob will know how/if to do this though.
>
> After reading the code I conclude this gpiochip is hierarchical so this should
> just be dropped, and we only need interrupt-parent assigned. The
> driver will know the hardware offsets between the interrupt parent
> and the GPIO block, this is generally the case for
> hierarchical interrupt controllers.
>
> Yours,
> Linus Walleij
>
next prev parent reply other threads:[~2021-03-02 21:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 16:42 [PATCH 00/12] pinctrl: add BCM63XX pincontrol support Álvaro Fernández Rojas
2021-02-25 16:42 ` [PATCH 01/12] Documentation: add BCM6328 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-02 14:57 ` Linus Walleij
2021-03-02 15:23 ` Linus Walleij
2021-03-02 16:53 ` Álvaro Fernández Rojas [this message]
2021-02-25 16:42 ` [PATCH 02/12] pinctrl: add a pincontrol driver for BCM6328 Álvaro Fernández Rojas
2021-03-02 15:20 ` Linus Walleij
2021-03-02 16:59 ` Álvaro Fernández Rojas
2021-02-25 16:42 ` [PATCH 03/12] Documentation: add BCM6358 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-02 15:22 ` Linus Walleij
2021-02-25 16:42 ` [PATCH 04/12] pinctrl: add a pincontrol driver for BCM6358 Álvaro Fernández Rojas
2021-03-02 15:25 ` Linus Walleij
2021-02-25 16:42 ` [PATCH 05/12] Documentation: add BCM6362 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-02 15:26 ` Linus Walleij
2021-02-25 16:42 ` [PATCH 06/12] pinctrl: add a pincontrol driver for BCM6362 Álvaro Fernández Rojas
2021-02-25 18:41 ` kernel test robot
2021-03-02 15:30 ` Linus Walleij
2021-02-25 16:42 ` [PATCH 07/12] Documentation: add BCM6368 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-02 15:27 ` Linus Walleij
2021-02-25 16:42 ` [PATCH 08/12] pinctrl: add a pincontrol driver for BCM6368 Álvaro Fernández Rojas
2021-03-02 15:27 ` Linus Walleij
2021-02-25 16:42 ` [PATCH 09/12] Documentation: add BCM63268 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-02 15:28 ` Linus Walleij
2021-02-25 16:42 ` [PATCH 10/12] pinctrl: add a pincontrol driver for BCM63268 Álvaro Fernández Rojas
2021-03-02 15:28 ` Linus Walleij
2021-02-25 16:42 ` [PATCH 11/12] Documentation: add BCM6318 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-02 15:29 ` Linus Walleij
2021-02-25 16:42 ` [PATCH 12/12] pinctrl: add a pincontrol driver for BCM6318 Álvaro Fernández Rojas
2021-03-02 15:30 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418daebd-b35b-2edc-6f33-591bd97ba1f9@gmail.com \
--to=noltari@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fazilyildiran@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).