From: "Heiko Stübner" <heiko@sntech.de>
To: "João H. Spies" <jhlspies@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Jianqun Xu <jay.xu@rock-chips.com>,
Maya Matuszczyk <maccraft123mc@gmail.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: rockchip: Enhance support for IRQ_TYPE_EDGE_BOTH
Date: Tue, 23 Aug 2022 12:00:34 +0200 [thread overview]
Message-ID: <4242490.iIbC2pHGDl@diego> (raw)
In-Reply-To: <CACRpkda6VoNjJfKY3+oCvdB+V6O_4cumKpjVSdBb9e8mEmHF6g@mail.gmail.com>
Am Montag, 22. August 2022, 11:03:08 CEST schrieb Linus Walleij:
> On Mon, Aug 8, 2022 at 4:53 AM João H. Spies <jhlspies@gmail.com> wrote:
>
> > Switching between falling/rising edges for IRQ_TYPE_EDGE_BOTH on pins that
> > require debounce can cause the device to lose events due to a desync
> > between pin state and irq type.
> >
> > This problem is resolved by switching between IRQ_TYPE_LEVEL_LOW and
> > IRQ_TYPE_LEVEL_HIGH instead.
> >
> > Fixes: 936ee26 ("gpio/rockchip: add driver for rockchip gpio")
> > Signed-off-by: João H. Spies <jhlspies@gmail.com>
>
> No reaction from maintainers so I'm just gonna assume this fix is
> correct and applied for fixes.
This plays with behavioral peculiarities of the gpio controller
(using the level setting to hopefully prevent missing edge irqs),
so doesn't follow
So I guess it really is more of a wait-and-see. And I guess as João
seems to have experienced that issue, that will hopefully work
for others too.
Heiko
prev parent reply other threads:[~2022-08-23 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 2:51 [PATCH] pinctrl: rockchip: Enhance support for IRQ_TYPE_EDGE_BOTH João H. Spies
2022-08-22 9:03 ` Linus Walleij
2022-08-23 10:00 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4242490.iIbC2pHGDl@diego \
--to=heiko@sntech.de \
--cc=brgl@bgdev.pl \
--cc=jay.xu@rock-chips.com \
--cc=jhlspies@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).