From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode Date: Wed, 23 Nov 2016 19:32:48 +0100 Message-ID: <42f5df18-2edd-08f2-a833-9c92ac85e87c@gmail.com> References: <1462868614-20602-1-git-send-email-chunfeng.yun@mediatek.com> <1462868614-20602-7-git-send-email-chunfeng.yun@mediatek.com> <1462991546.11623.3.camel@mussux00> <1463017282.11651.82.camel@mhfsdcap03> <1463018942.1608.5.camel@mussux00> <1463021701.25171.5.camel@mussux00> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1463021701.25171.5.camel@mussux00> Sender: linux-kernel-owner@vger.kernel.org To: Hongzhou Yang , chunfeng yun Cc: Linus Walleij , Maoguang Meng , Yingjoe Chen , Greg Kroah-Hartman , Felipe Balbi , Mathias Nyman , Alan Stern , Rob Herring , Mark Rutland , Ian Campbell , Sergei Shtylyov , Pawel Moll , Kumar Gala , Sascha Hauer , Biao Huang , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , linux-kernel@vger.kernel List-Id: linux-gpio@vger.kernel.org Hi Hongzhou, On 12/05/16 04:55, Hongzhou Yang wrote: > On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote: >> On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote: >>> Hi, >>> >>> On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote: >>>> On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: >>>>> On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun >>>>> wrote: >>>>> >>>>>> the default mode of GPIO16 pin is gpio, when set EINT16 to >>>>>> IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be >>>>>> fixed when set its default mode as usb iddig. >>>>>> >>>>>> Signed-off-by: Chunfeng Yun >>>>> >>>> >>>> Chunfeng, GPIO16 can be used as EINT16 mode, but the pinmux should be 0. >>>> If you want to set its default mode to iddig, you should set it in dts. >>>> >>> I set it in DTS, but it didn't work, because when usb driver requested >>> IRQ, pinmux was switched back to default mode set by >>> MTK_EINT_FUNCTION(). >>> >> >> After confirmed, there are something wrong with data sheet and pinmux >> table, and GPIO16 can only receive interrupt by mode 1. So >> >> Acked-by: Hongzhou Yang >> > > Linus, > > We find there are some other pins still have the same problem, so please > hold on it. Sorry for so much noise. > Did you made any progress on this? I didn't see any patch on the mailing list. Regards, Matthias