From: Dmitry Torokhov <dtor@chromium.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map
Date: Fri, 14 Nov 2014 16:44:06 -0800 [thread overview]
Message-ID: <4324315.2x5Mj9E2n5@dtor-glaptop> (raw)
In-Reply-To: <20141114235307.GF1739@jhogan-linux.le.imgtec.org>
On Friday, November 14, 2014 11:53:07 PM James Hogan wrote:
> On Fri, Nov 14, 2014 at 01:32:56PM -0800, Dmitry Torokhov wrote:
> > irq_of_parse_and_map() returns 0 on error, so testing for negative
> > result never works.
> >
> > Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
>
> Good catch, thanks!
>
> Acked-by: James Hogan <james.hogan@imgtec.com>
>
> A quick coccinelle script shows up numerous other cases of this error
> around the kernel tree too...
Yeah, I sent out a few patches today.
Thanks,
Dmitry
next prev parent reply other threads:[~2014-11-15 0:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 21:32 [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-14 23:53 ` James Hogan
2014-11-15 0:44 ` Dmitry Torokhov [this message]
2014-11-27 13:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4324315.2x5Mj9E2n5@dtor-glaptop \
--to=dtor@chromium.org \
--cc=gnurou@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox