From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: bartosz.golaszewski@linaro.org, linus.walleij@linaro.org,
Hector Palacios <hector.palacios@digi.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
haibo.chen@nxp.com, peng.fan@nxp.com, hector.palacios@digi.com
Subject: Re: [PATCH 2/2] arm64: dts: imx93: specify available 'ngpios' per GPIO port
Date: Thu, 11 Jan 2024 15:26:29 +0100 [thread overview]
Message-ID: <4330477.ejJDZkT8p0@steina-w> (raw)
In-Reply-To: <20240111131904.1491496-3-hector.palacios@digi.com>
Am Donnerstag, 11. Januar 2024, 14:19:04 CET schrieb Hector Palacios:
> According to NXP HRM for i.MX93, the following GPIO pins are available:
> - GPIO1: 16 pins (0..15)
> - GPIO2: 30 pins (0..29)
> - GPIO3: 32 pins (0..31)
> - GPIO4: 30 pins (0..29)
>
> Signed-off-by: Hector Palacios <hector.palacios@digi.com>
> ---
> arch/arm64/boot/dts/freescale/imx93.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi index 34c0540276d1..7eb2cab7c749
> 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -970,6 +970,7 @@ gpio2: gpio@43810000 {
> <&clk IMX93_CLK_GPIO2_GATE>;
> clock-names = "gpio", "port";
> gpio-ranges = <&iomuxc 0 4 30>;
> + ngpios = <30>;
> };
>
> gpio3: gpio@43820000 {
> @@ -986,6 +987,7 @@ gpio3: gpio@43820000 {
> clock-names = "gpio", "port";
> gpio-ranges = <&iomuxc 0 84 8>, <&iomuxc 8 66
18>,
> <&iomuxc 26 34 2>, <&iomuxc 28 0
4>;
> + ngpios = <32>;
> };
>
> gpio4: gpio@43830000 {
> @@ -1001,6 +1003,7 @@ gpio4: gpio@43830000 {
> <&clk IMX93_CLK_GPIO4_GATE>;
> clock-names = "gpio", "port";
> gpio-ranges = <&iomuxc 0 38 28>, <&iomuxc 28 36
2>;
> + ngpios = <30>;
> };
>
> gpio1: gpio@47400000 {
> @@ -1016,6 +1019,7 @@ gpio1: gpio@47400000 {
> <&clk IMX93_CLK_GPIO1_GATE>;
> clock-names = "gpio", "port";
> gpio-ranges = <&iomuxc 0 92 16>;
> + ngpios = <16>;
> };
>
> ocotp: efuse@47510000 {
This leads to warnings upon dtbs_check, e.g.
arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dtb: gpio@43810000:
'ngpios' does not match any of the regexes: '^.+-hog(-[0-9]+)?$', 'pinctrl-
[0-9]+'
from schema $id: http://devicetree.org/schemas/gpio/gpio-vf610.yaml#
Please address this as well.
Best regards,
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2024-01-11 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 13:19 [PATCH 0/2] support i.MX93 truly available GPIO pins Hector Palacios
2024-01-11 13:19 ` [PATCH 1/2] gpio: vf610: add support to DT 'ngpios' property Hector Palacios
2024-01-11 14:22 ` Linus Walleij
2024-01-11 13:19 ` [PATCH 2/2] arm64: dts: imx93: specify available 'ngpios' per GPIO port Hector Palacios
2024-01-11 14:26 ` Alexander Stein [this message]
2024-01-11 13:53 ` [PATCH 0/2] support i.MX93 truly available GPIO pins Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4330477.ejJDZkT8p0@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=haibo.chen@nxp.com \
--cc=hector.palacios@digi.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).