From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linus.walleij@linaro.org>, Huang-Huang Bao <i@eh5.me>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Huang-Huang Bao <i@eh5.me>
Subject: Re: [PATCH 2/3] pinctrl: rockchip: use dedicated pinctrl type for RK3328
Date: Thu, 06 Jun 2024 12:11:15 +0200 [thread overview]
Message-ID: <4429508.MSiuQNM8U4@diego> (raw)
In-Reply-To: <2182307.KiezcSG77Q@diego>
Am Donnerstag, 6. Juni 2024, 11:43:56 CEST schrieb Heiko Stübner:
> Am Donnerstag, 6. Juni 2024, 08:04:34 CEST schrieb Huang-Huang Bao:
> > rk3328_pin_ctrl uses type of RK3288 which has a hack in
> > rockchip_pinctrl_suspend and rockchip_pinctrl_resume to restore GPIO6-C6
> > at assume, the hack is not applicable to RK3328 as GPIO6 is not even
> > exist in it. So use a dedicated pinctrl type to skip this hack.
> >
> > Signed-off-by: Huang-Huang Bao <i@eh5.me>
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
I think this actually also warrants a Fixes-tag, because as you said, the
suspend handling for the rk3288 will change GRF registers it should not
touch on the rk3328.
Fixes: 3818e4a7678e ("pinctrl: rockchip: Add rk3328 pinctrl support")
next prev parent reply other threads:[~2024-06-06 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240606060435.765716-1-i@eh5.me>
2024-06-06 6:04 ` [PATCH 1/3] pinctrl: rockchip: fix RK3328 pinmux bits Huang-Huang Bao
2024-06-06 10:08 ` Heiko Stübner
2024-06-06 11:25 ` Huang-Huang Bao
2024-06-06 6:04 ` [PATCH 2/3] pinctrl: rockchip: use dedicated pinctrl type for RK3328 Huang-Huang Bao
2024-06-06 9:43 ` Heiko Stübner
2024-06-06 10:11 ` Heiko Stübner [this message]
2024-06-06 6:04 ` [PATCH 3/3] pinctrl: rockchip: fix pinmux reset in rockchip_pmx_set Huang-Huang Bao
2024-06-06 9:51 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4429508.MSiuQNM8U4@diego \
--to=heiko@sntech.de \
--cc=i@eh5.me \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).