From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C54B40096A for ; Thu, 27 Aug 2026 08:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787820820; cv=none; b=P3Vf92ossK6WLNKwGpe/tplD54/YUYz6hJONeYIMz8qsxicofrUXwmXCPnvCTKwl3u6yhob4CHbDW4hC2HFWW7LQoO+QzIuF9s/RWHQydkMlpkTMVx9Nf3fUL9cZK/FIiVR4CcvNBYeB0IRS2lmcvaDT+f+S8+9FV4NL6P4Wfwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787820820; c=relaxed/simple; bh=YADBMXSnCng14KUNiClp3iNmXFAtu/uigmJzZWl3z6Q=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=dSkaLApesd1J8ILcHy2PFGxejE/ro2p0sjYOYHy4A5izSFZ7QNth8qi09Zvu3hdwJXzBFR6I8HB0A8NlYN4N+VEB7MxfCje4KgbRzVFIs6G7ZQBqGJRJfrgy7xtA6mnbGdvrB8pde8NQq+rvZtNS6SPrIGFtbXSyiZI0nEze+G4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AyEV9n+Y; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AyEV9n+Y" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-482c58a8683so311115f8f.0 for ; Thu, 27 Aug 2026 01:53:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787820816; x=1788425616; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zVehDwDn3vUosVzDAVI89hDucj1hjpgV8XEbxurpbsY=; b=AyEV9n+YtptU35ft84mZWxovrUoVl36FuhhnX+MawP0KM9vCd1zEmQ65oI1eMXX2I+ U42/3kOelm+8Y/h4a2EmApr9AUE6Ad54DY5WBKVNLoGBOwEMYDkgDcvgn4FE0MnunxyU zSc7pVYxkNpmb0xTNJWeXtpIHpLpkkkr53unlRpmUOMzRXsW2tF25MmRD0yrdPgqJSIw gQ9uwV9C0QlVTh2ortescCjWnZVUWT+cT4nTRh1VbGDgNtYIoRWW/v6uYrHwVN3sAzDp ZBx1439B83MTZuhxhcf+FynHMy2QpeFeckCiPoXdKEwWDRNA96/9cIZ/nl43Bp4maJmf ChGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787820816; x=1788425616; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=zVehDwDn3vUosVzDAVI89hDucj1hjpgV8XEbxurpbsY=; b=JtbhZjJkAwyF+iWWRy0iepitMAeq9fwo/psw099YQW1YHDnrBKtOA7cmbI9ShuGUxM ybCOP/DtEt12grU2lihiBj97mlsdsNzPZb21QNJn3KyIFEtUeEZcOrC6iC7Id+ejfc32 JIJoB4JD87PwChHGTJXPztbu8oMW32sXisRmyufuvPb1bUcRYp3ufa/uvo7gcsoqdZUJ atLn6nUwKjFg6jnAKiL9xwBttW6jq+Ebn1295KKNOqykhWo2OYh2aydGW9jCf6LFLPEZ BdfI0tphYnmwHAjhH63bDql1ELdBrOyw1U+7dbldx+2JjIaFbtWabsJ8xH/7NU6R8zla 5gBg== X-Forwarded-Encrypted: i=1; AHgh+Rrg3Ie7QajU4UsjVamVdvg+/9yQ4OJf+m7Gk9WVMMUX/lUaNqMxSAGqBBHD45oVBO8tqt4OIs2IPfdN@vger.kernel.org X-Gm-Message-State: AFuF++nD5Oq2JQJnmXtu5+wZ0ft020NAuWQzjH81/eZVn/8Wx52qkCFP bqVox7UTCf8gpcOIUfYhYpwvbNr4rz7bqldv/5/k4zZugXzDDclukxgcEr9dUmApsrQ= X-Gm-Gg: AR+sD13MCNQWot0TCCzWPw8e2V0JVlvkR1Vc7hOLpTj9zBSao4SRntikhzY2nM71Rxj INr+f7Q0bmHUubLsA1+HbV2K8WdK6GGbj2nXOqC3aYjLXW5JbxAe2p6nkYu6fV/bLqMJhfCRB8k fVfDhsx9cxfSkoJbnwVg4DkHKkDduzkgoxSYlWyuV7mBiViE1O2SAS7P6rHflcHsWlC7aAFlfDA 9Gr25emb/tIvlvXSWQooZfWDugixx0pELuYG8GvBE3Hxz7I/i3x9N+DkKZfyFH2f2174G990D4G qkF+J4+N8eER4oPKhKcnVhb/jclVGDt6tVo8IDo4wwfw8DoJQfcxjHP6mOx6PoEICOMix0JDEjL fdOdl5r4ncB/GEe3qmb8rzt2Y4rfPqI+iMH337dhRoXIrxLFFkAnOHzyJMp0Soch+3kDWb8MLXX N411XswfE4rUGi+S+tjrug+n0o2bRPIwVLq0SYbD31FsH4VIDOHOtKkH0s09fmS3CzWfLG X-Received: by 2002:a05:6000:310e:b0:482:ebb0:d00f with SMTP id ffacd0b85a97d-482ebb0d2dcmr5858920f8f.5.1787820816409; Thu, 27 Aug 2026 01:53:36 -0700 (PDT) Received: from [172.20.10.4] ([37.165.68.39]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482e27a9f0esm8105572f8f.10.2026.08.27.01.53.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2026 01:53:35 -0700 (PDT) Message-ID: <444d0f8f-e669-4267-b28c-697e205df51f@linaro.org> Date: Thu, 27 Aug 2026 10:53:02 +0200 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH] pinctrl: meson: Fix typo in s4 group name To: Sean Anderson , Linus Walleij , Kevin Hilman , linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org Cc: Martin Blumenstingl , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Qianggui Song , Jerome Brunet References: <20260817162212.1890616-1-sanderson@brivo.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260817162212.1890616-1-sanderson@brivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/17/26 18:22, Sean Anderson wrote: > One of the i2c pin groups has some junk at the end. The name should be > i2c2_scl_h1, and indeed that's the name used by i2c2_pins3 in > meson-s4.dtsi. > > Fixes: 775214d389c25 ("pinctrl: meson: add pinctrl driver support for Meson-S4 Soc") > Signed-off-by: Sean Anderson > --- > > drivers/pinctrl/meson/pinctrl-meson-s4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/meson/pinctrl-meson-s4.c b/drivers/pinctrl/meson/pinctrl-meson-s4.c > index 872948699e9fe..365dafe457a9f 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson-s4.c > +++ b/drivers/pinctrl/meson/pinctrl-meson-s4.c > @@ -854,7 +854,7 @@ static const char * const i2c1_groups[] = { > static const char * const i2c2_groups[] = { > "i2c2_sda_d", "i2c2_scl_d", > "i2c2_sda_h8", "i2c2_scl_h9", > - "i2c2_sda_h0", "i2c2_scl_h1l," > + "i2c2_sda_h0", "i2c2_scl_h1", > }; > > static const char * const i2c3_groups[] = { > --- > base-commit: 3b5f4b83c4abc0c9b0a7b9e2b44e816611b7f2ec > branch: meson_pinctrl_group > Reviewed-by: Neil Armstrong Thanks, Neil