From: Andrew Davis <afd@ti.com>
To: <andy.shevchenko@gmail.com>
Cc: Peter Tyser <ptyser@xes-inc.com>,
Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] gpio: pisosr: Use devm_gpiochip_add_data() to simplify remove path
Date: Tue, 16 May 2023 10:24:11 -0500 [thread overview]
Message-ID: <44a19ea6-a7e3-51bb-6631-b7514ef88219@ti.com> (raw)
In-Reply-To: <ZGJ7POc8Qm9pE_WZ@surfacebook>
On 5/15/23 1:34 PM, andy.shevchenko@gmail.com wrote:
> Mon, May 15, 2023 at 12:43:21PM -0500, Andrew Davis kirjoitti:
>> Use devm version of gpiochip add function to handle removal for us.
>>
>> While here update copyright and module author.
>
> ...
>
>> +static void pisosr_mutex_destroy(void *data)
>> +{
>> + struct mutex *lock = data;
>> +
>> + mutex_destroy(lock);
>> +}
>
> No need to cast void * explicitly.
>
No need sure, but I really think it looks cleaner to be
explicit with the types here. If you feel strongly I
can change it though.
Andrew
> static void pisosr_mutex_destroy(void *lock)
> {
> mutex_destroy(lock);
> }
>
next prev parent reply other threads:[~2023-05-16 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 17:43 [PATCH v3] gpio: pisosr: Use devm_gpiochip_add_data() to simplify remove path Andrew Davis
2023-05-15 18:34 ` andy.shevchenko
2023-05-16 15:24 ` Andrew Davis [this message]
2023-05-16 18:25 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44a19ea6-a7e3-51bb-6631-b7514ef88219@ti.com \
--to=afd@ti.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptyser@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox