From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B28C4C3F2D3 for ; Fri, 28 Feb 2020 11:22:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8706D246A0 for ; Fri, 28 Feb 2020 11:22:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TAAPsoWn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725884AbgB1LWx (ORCPT ); Fri, 28 Feb 2020 06:22:53 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:26857 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725730AbgB1LWx (ORCPT ); Fri, 28 Feb 2020 06:22:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582888972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7BnoaA17pJMFu998jYGiIMsNzgI1x+bmJkwrgednNKw=; b=TAAPsoWncSBziwjY2E94ZZ/dKl5aUEC0ibIkq0I6QhLo6ZYRpM9PSyS4tGS9Karpgal+jY 43g6YDfbwM54cmollXJzxN4tEfIW23KJkrHk6gCv0irLsUItQsujQRO4SACEJR9ICUTd/z 3zltpZfof2LoGd3/Eow9OGGeWHra2/c= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-7icjO7ALMK-gE724r4RYmw-1; Fri, 28 Feb 2020 06:22:48 -0500 X-MC-Unique: 7icjO7ALMK-gE724r4RYmw-1 Received: by mail-wm1-f72.google.com with SMTP id m4so1028096wmi.5 for ; Fri, 28 Feb 2020 03:22:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7BnoaA17pJMFu998jYGiIMsNzgI1x+bmJkwrgednNKw=; b=EPoydhwiRyNi9psd96mWCsiTdcIpf2j+V9tQ0VV6IeS7C1wTpn4XgGrIKcKZm1YJOv wAOX14k1UJUO1h05CWWbWzs9WxjGEkQRCxsazvOT4aQF/jZJUcjo45U1aRG9Wzq0/7Iz pXEcgMiCSrQRPZGrU7AMUVjzVOIKx2MvuCTzNK96+WXyak+QGHX++KoJafDrPbeNAqFg Ptg9FzbWc4G5SaeItiyCJyq0DNISEdPZOAwFkN4XmNHcw6qqq9PG9O56ToRuL7cAI9JF K1haiLI1fqFj2SbNJgiEOzsIBjKW62JSvRvGCB0TLaj7/ERnNA33unTHR9nVp2FoHUvm Qf2Q== X-Gm-Message-State: APjAAAUSRfa5ojxK9Wdg73i/TlNmDQ7OJilA6hEPdRA0aQUaqvvgcU53 7PHKWe3D53+Q0f5yUeIKqumA5ah4PFMVkiOvzmb+jt/2GcqPeOPKgAKM/iyCwLSccQSPzoDpo/i laAKG1OWD6yZDBSi8GNzlJw== X-Received: by 2002:adf:ed4c:: with SMTP id u12mr4721419wro.204.1582888967640; Fri, 28 Feb 2020 03:22:47 -0800 (PST) X-Google-Smtp-Source: APXvYqwUfcO5YrOruRLOgiKuOdm1ewT6kk5ie3QhpLjqx3kLXtS0X76Pmw47xD73u0WNOD3WguS+sw== X-Received: by 2002:adf:ed4c:: with SMTP id u12mr4721394wro.204.1582888967400; Fri, 28 Feb 2020 03:22:47 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c0c-fe00-fc7e-fd47-85c1-1ab3.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:fc7e:fd47:85c1:1ab3]) by smtp.gmail.com with ESMTPSA id a62sm1786454wmh.33.2020.02.28.03.22.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Feb 2020 03:22:46 -0800 (PST) Subject: Re: [PATCH resend 2/3] gpiolib: acpi: Rename honor_wakeup option to ignore_wake, add extra quirk To: Andy Shevchenko Cc: Mika Westerberg , Bartosz Golaszewski , Linus Walleij , Marc Lehmann , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org References: <20200225102753.8351-1-hdegoede@redhat.com> <20200225102753.8351-3-hdegoede@redhat.com> <20200225105437.GG10400@smile.fi.intel.com> <20200225123425.GK10400@smile.fi.intel.com> <20200225125700.GL10400@smile.fi.intel.com> From: Hans de Goede Message-ID: <44cc5510-571c-21c4-1855-f3141f72eaa3@redhat.com> Date: Fri, 28 Feb 2020 12:22:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200225125700.GL10400@smile.fi.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi, On 2/25/20 1:57 PM, Andy Shevchenko wrote: > On Tue, Feb 25, 2020 at 02:34:25PM +0200, Andy Shevchenko wrote: >> On Tue, Feb 25, 2020 at 12:26:04PM +0100, Hans de Goede wrote: > >> Let's do it as a list of pairs, but in slightly different format (I see some >> potential to derive a generic parser, based on users described in >> Documentation/admin-guide/kernel-parameters.txt), i.e. >> >> ignore_wake=pin:controller[,pin:controller[,...]] > > Another possible format > > ignore_wake=controller@pin[;controller@pin[;...]] I like this one, the other one with the pin first feels wrong, the pin is part of the controller, not the other way around. I will rework the patch series to use the ignore_wake=controller@pin format. > The second one, while having less users, can be extended to have list of pins > of the same controller, like > > ignore_wake=controller@pin[:pin2:pin3][;controller@pin[:...][;...]] I don't really see a need for this, the controller name can be repeated in the unlikely case where more then one pin needs to be blacklisted from wakeup and I would like to keep the parsing as KISS as possible. I guess we can always add this later if people feel like adding it. Regards, Hans